-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: kube-apiserver tag will overwrite secrets-at-rest token if used independently #10460
Fix: kube-apiserver tag will overwrite secrets-at-rest token if used independently #10460
Conversation
|
Hi @jwitko. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…independently Signed-off-by: Jason Witkowski <[email protected]>
9e6fc90
to
d8817e4
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jwitko Thank you for the PR 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jwitko
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, jwitko, mzaian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…independently (kubernetes-sigs#10460) Signed-off-by: Jason Witkowski <[email protected]>
…independently (kubernetes-sigs#10460) Signed-off-by: Jason Witkowski <[email protected]>
What type of PR is this?
/kind bug
What this PR does / why we need it:
If a user runs
update-cluster.yml
with tagkube-apiserver
the playbook will not check whether or not the secrets-at-rest encryption token is already defined and will instead generate a new token and replace it potentially rendering secrets into an inaccessible and unrecoverable state.This PR applies the tag to all tasks in the file as they are all needed to properly determine the course of action.
Which issue(s) this PR fixes:
Fixes #10459
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE