Fix Kubelet not starting because of non-existent feature gate

[Smidra]

What type of PR is this?
/kind documentation
Fixes #10250

What this PR does / why we need it:
When installing latest Kubernetes with Kubespray and the Openstack cloud provider the documentation instructs to enable 3 feature gates.

kube_feature_gates:
- CSIMigration=true
- CSIMigrationOpenStack=true
- ExpandCSIVolumes=true

Specified feature gates cause Kubelets and whole Kubespray to fail. Kubelet fails to start because the specified feature gate do not exist. The features have graduated and thus the gates were removed.

Which issue(s) this PR fixes:

Special notes for your reviewer:
Hello there, first PR in my life. 😄

Does this PR introduce a user-facing change?:

Removed not needed graduated feature gates.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Smidra / name: Radek Smid (67ea7af)

[k8s-ci-robot]

Welcome @Smidra!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Smidra. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[floryut]

@Smidra Thank you, one comment though
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, Smidra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[floryut]

Can you please check CLA ?
/ok-to-test

[Smidra]

Can you please check CLA ? /ok-to-test

Signed. I had to consult with managment first.

[yankay]

/ok-to-test

[Smidra]

This issue is okay to test for 3 weeks now. The build for rocky linux is still running - the fix is pretty simple documentation stuff. Any ideas what had gone wrong? Thanks.

[MrFreezeex]

This issue is okay to test for 3 weeks now. The build for rocky linux is still running - the fix is pretty simple documentation stuff. Any ideas what had gone wrong? Thanks.

Ci job has been misreported from gitlab to github, don't worry about it. Could you check #10448 (comment) as well?

[floryut]

This issue is okay to test for 3 weeks now. The build for rocky linux is still running - the fix is pretty simple documentation stuff. Any ideas what had gone wrong? Thanks.

Ci job has been misreported from gitlab to github, don't worry about it. Could you check #10448 (comment) as well?

@Smidra are you still available for this ?

[Smidra]

This issue is okay to test for 3 weeks now. The build for rocky linux is still running - the fix is pretty simple documentation stuff. Any ideas what had gone wrong? Thanks.

Ci job has been misreported from gitlab to github, don't worry about it. Could you check #10448 (comment) as well?

@Smidra are you still available for this ?

Sorry, for the delay. Now it should be okay.

[floryut]

This issue is okay to test for 3 weeks now. The build for rocky linux is still running - the fix is pretty simple documentation stuff. Any ideas what had gone wrong? Thanks.

Ci job has been misreported from gitlab to github, don't worry about it. Could you check #10448 (comment) as well?

@Smidra are you still available for this ?

Sorry, for the delay. Now it should be okay.

Wow sorry missed that 😆
Can you rebase ?

[floryut]

@Smidra I'm real sorry about that, but could you update to match the fact that master will soon support only k8s 1.28+

So maybe put some example for newer one and remove all non supported one ? https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/

Still would like to merge this one :/

[Smidra]

@floryut No problem, that makes sence. How about this?

[floryut]

@floryut No problem, that makes sence. How about this?

Thanks, can you check the markdown linter ?

[Smidra]

@floryut Markdown lint fixed.

[floryut]

Conflict with #10879
Probably best to remove them in fact 🤔

[LarssonOliver]

This PR likely fixes #10250

[VannTen]

Min kubernetes version in master is 1.27.0, so I think you can just remove any mention of features gates in that doc.
If you could also add Fixes #10250 in the PR description that would help 👍

[Smidra]

@VannTen Users might want to specify custom feature gates - is nice to show them how. Do you still want me to remove all the lines concerning feature gates (lilnes 68-75)?

[VannTen]

@VannTen Users might want to specify custom feature gates - is nice to show them how. Do you still want me to remove all the lines concerning feature gates (lilnes 68-75)?

Yes they migth, but that's not specific to Openstack, and it's already documented in docs/vars.md. No need to repeat ourselves !

[VannTen]

Thanks ! Could you squash/fixup your commits ? The first commit message is good but one commit should be enough for this change

[Smidra]

Squashed to commit 8af479c

[VannTen]

Hum that does not look right you should have only one commit after your squash.
(in a terminal, that would be git rebase -i master when on your PR branch, and then changing every line except the first from pick to fixup ( or squash if you want to modify the commit message). You'll then need to force push.

[Smidra]

@VannTen How about this?

[VannTen]

/lgtm