Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.23] Add hashes for kubernetes version 1.25.14, 1.27.6 & 1.26.9 #10443

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

bozzo
Copy link
Contributor

@bozzo bozzo commented Sep 17, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind feature

What this PR does / why we need it:
Add hashes for version 1.27.6 & 1.26.9

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Based on #10435

Does this PR introduce a user-facing change?:

Add hashes for kubernetes 1.27.6 & 1.26.9

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 17, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 17, 2023
@bozzo bozzo changed the title [2.23] Add hashes for kubernetes version 1.27.6 & 1.26.9 [2.23] Add hashes for kubernetes version 1.25.14, 1.27.6 & 1.26.9 Sep 17, 2023
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bozzo Thanks 🙇

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bozzo, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2023
@mzaian
Copy link
Contributor

mzaian commented Sep 18, 2023

Thanks a lot @bozzo

We are no longer adding hashes for 1.25.x

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2023
@floryut
Copy link
Member

floryut commented Sep 18, 2023

Thanks a lot @bozzo

We are no longer adding hashes for 1.25.x

/hold

Well 2.23 was still supporting 1.25, so no harm in adding them I guess

@mzaian
Copy link
Contributor

mzaian commented Sep 18, 2023

Thanks a lot @bozzo
We are no longer adding hashes for 1.25.x
/hold

Well 2.23 was still supporting 1.25, so no harm in adding them I guess

I missed that that it's going to the release branch. Sorry @bozzo and Thanks a lot

/unhold
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit a4b0656 into kubernetes-sigs:release-2.23 Sep 18, 2023
@bozzo
Copy link
Contributor Author

bozzo commented Sep 18, 2023

Thanks a lot @bozzo
We are no longer adding hashes for 1.25.x
/hold

Well 2.23 was still supporting 1.25, so no harm in adding them I guess

I missed that that it's going to the release branch. Sorry @bozzo and Thanks a lot

/unhold /lgtm

@mzaian no problem 😃 .
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants