Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to configure restarted networking service name in reset. #10428

Merged

Conversation

RomainMou
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
When running the reseting playbook, the networking service may be restart and there is no way to configure the name of the service.
The guessing is very basic and may not work in all cases (for example the Debian 12 cloud image use Netplan + Networkd by default).
This PR fixes that by letting the end-user the ability to manually configure the service name.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add a variable reset_restart_network_service_name in the reset role to be able to configure the name of the service which is restarted.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 12, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @RomainMou. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 12, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 12, 2023
@yankay
Copy link
Member

yankay commented Sep 13, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 13, 2023
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RomainMou Thank you

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, RomainMou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2023
@RomainMou
Copy link
Contributor Author

RomainMou commented Sep 20, 2023

@RomainMou Thank you

My pleasure.

Sorry @floryut, this is my first PR here, so I'm not sure how the process works. Do I need to do something else for this PR or everything is ok?

@yankay
Copy link
Member

yankay commented Sep 20, 2023

Thanks @RomainMou

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit a81c6d5 into kubernetes-sigs:master Sep 20, 2023
@floryut
Copy link
Member

floryut commented Sep 21, 2023

@RomainMou Thank you

My pleasure.

Sorry @floryut, this is my first PR here, so I'm not sure how the process works. Do I need to do something else for this PR or everything is ok?

Nothing PR needs 2 pair of eyes, one for approval of the change and "authorization" and one for lgtm of the codebase
You were missing the second one, done by @yankay yesterday and now automatically merge 👍

@RomainMou RomainMou deleted the feat/network-service-detection branch September 25, 2023 09:53
guytet pushed a commit to guytet/kubespray that referenced this pull request Oct 30, 2023
@yankay yankay mentioned this pull request Dec 15, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants