-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a way to configure restarted networking service name in reset. #10428
Add a way to configure restarted networking service name in reset. #10428
Conversation
Hi @RomainMou. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RomainMou Thank you
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, RomainMou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
My pleasure. Sorry @floryut, this is my first PR here, so I'm not sure how the process works. Do I need to do something else for this PR or everything is ok? |
Thanks @RomainMou /lgtm |
Nothing PR needs 2 pair of eyes, one for approval of the change and "authorization" and one for lgtm of the codebase |
What type of PR is this?
/kind bug
What this PR does / why we need it:
When running the reseting playbook, the networking service may be restart and there is no way to configure the name of the service.
The guessing is very basic and may not work in all cases (for example the Debian 12 cloud image use Netplan + Networkd by default).
This PR fixes that by letting the end-user the ability to manually configure the service name.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: