Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for calico_iptables_backend in Redhat/Centos.md #10417

Merged

Conversation

yankay
Copy link
Member

@yankay yankay commented Sep 7, 2023

What type of PR is this?

/kind documentation

What this PR does / why we need it:

After the calico 3.25.2 updated #10414 ,
The issue has been fixed by projectcalico/calico#7460

The auto mode is worked fine in the Redhat/Centos 8, so there is no need for the docs to change the calico_iptables_backend to NFT.

Which issue(s) this PR fixes:

Fixes #9005

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update docs for calico_iptables_backend in Redhat/Centos.md

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 7, 2023
@k8s-ci-robot k8s-ci-robot requested a review from bozzo September 7, 2023 10:26
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 7, 2023
@k8s-ci-robot k8s-ci-robot requested a review from mzaian September 7, 2023 10:26
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 7, 2023
@yankay yankay force-pushed the update-docs-for-calico-in-centos branch from 3f25621 to 1827f4d Compare September 7, 2023 10:27
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yankay

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2023
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This could go into the release I guess, putting it on hold to prevent auto merging if this needs to be discussed

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, mzaian, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floryut,mzaian,yankay]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mzaian mzaian removed their assignment Sep 7, 2023
@floryut
Copy link
Member

floryut commented Sep 8, 2023

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit 293573c into kubernetes-sigs:master Sep 8, 2023
guytet pushed a commit to guytet/kubespray that referenced this pull request Oct 30, 2023
@yankay yankay mentioned this pull request Dec 15, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement Request: Avoid use the "calico_iptables_backend=Auto" in Centos 8
4 participants