Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup recover control plane playbook + add debian12/cilium test #10411

Merged

Conversation

floryut
Copy link
Member

@floryut floryut commented Sep 4, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixing https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/5005826473 and https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/5005826332 which are failing with "The conditional check 'not has_quorum' failed. error
Also fixing warning [WARNING]: Could not match supplied host pattern, ignoring: kube_control_plane:!fake_hosts as ansible don't like mixing "," and ":".

Which issue(s) this PR fixes:
None

Special notes for your reviewer:
Commit which broke this playbook: 25cb90b
Last but not least, I need a new debian12 test to validate debian12 with cilium 😛

Does this PR introduce a user-facing change?:

Fixup recover_control_plane playbook (also add debian 12 with cilium as a new nightly test)

@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 4, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 4, 2023
@floryut floryut force-pushed the feat_add_cilium_testing branch from d1fa431 to c801aa9 Compare September 4, 2023 19:13
@floryut floryut force-pushed the feat_add_cilium_testing branch from c801aa9 to a4bc3ee Compare September 4, 2023 20:14
@floryut floryut changed the title Add debian12 cilium testing Fixup recover control plane playbook + add debian12/cilium test Sep 4, 2023
@floryut
Copy link
Member Author

floryut commented Sep 4, 2023

@floryut floryut mentioned this pull request Sep 4, 2023
@floryut floryut added kind/bug Categorizes issue or PR as related to a bug. and removed kind/flake Categorizes issue or PR as related to a flaky test. labels Sep 5, 2023
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @floryut

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 5, 2023
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 🙏
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, MrFreezeex, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9696936 into kubernetes-sigs:master Sep 5, 2023
guytet pushed a commit to guytet/kubespray that referenced this pull request Oct 30, 2023
…rnetes-sigs#10411)

* Add debian12 cilium testing

* Fixup recover control plane playbook
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
…rnetes-sigs#10411)

* Add debian12 cilium testing

* Fixup recover control plane playbook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants