Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kubernetes] support 1.28.0 / 1.28.1 (#10376) #10390

Merged
merged 2 commits into from
Sep 12, 2023
Merged

[kubernetes] support 1.28.0 / 1.28.1 (#10376) #10390

merged 2 commits into from
Sep 12, 2023

Conversation

tmurakam
Copy link
Contributor

@tmurakam tmurakam commented Aug 24, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds support for Kubernetes 1.28.0 / 1.28.1.

Which issue(s) this PR fixes:

Fixes #10376

Does this PR introduce a user-facing change?:

Add Kubernetes 1.28.0, 1.28.1.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 24, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @tmurakam. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 24, 2023
@yankay
Copy link
Member

yankay commented Aug 24, 2023

Thanks @tmurakam

Another PR is working for this #10387
And we need to wait for the the v2.23 release #10389

/ok-to-test
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 24, 2023
@yankay
Copy link
Member

yankay commented Aug 24, 2023

hold for the v2.23 release #10389

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2023
floryut
floryut approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmurakam Thank you 👍

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2023
@yankay yankay removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2023
@yankay
Copy link
Member

yankay commented Sep 11, 2023 •
edited
Loading

HI @tmurakam

We can also change the default kubernetes version to the 1.28 :-)
Ref to : https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubespray-defaults/defaults/main.yaml#L19

Thanks

@tmurakam
Copy link
Contributor Author

tmurakam commented Sep 11, 2023 •
edited
Loading

@yankay
Shall I change the default kubernetes version to 1.28 in this PR?
Or create another separeted PR?

@tmurakam tmurakam changed the title [kubernetes] support 1.28.0 (#10376) [kubernetes] support 1.28.0 / 1.28.1 (#10376) Sep 11, 2023
@tmurakam
Copy link
Contributor Author

I will add hashes for kubernetes 1.28.1 too.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 11, 2023
@yankay
Copy link
Member

yankay commented Sep 11, 2023

I will add hashes for kubernetes 1.28.1 too.

Both is OK :-)

@tmurakam
Copy link
Contributor Author

I pushed a new commit to make kubernetes 1.28.1 as default.

mzaian
mzaian approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tmurakam

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, mzaian, tmurakam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2023
@yankay
Copy link
Member

yankay commented Sep 12, 2023

Thanks @tmurakam

/lgtm
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 748b0b2 into kubernetes-sigs:master Sep 12, 2023
@tmurakam tmurakam deleted the add-k8s-1.28.0 branch September 12, 2023 03:37
guytet pushed a commit to guytet/kubespray that referenced this pull request Oct 30, 2023
@tmurakam
[kubernetes] support 1.28.0 / 1.28.1 (kubernetes-sigs#10376) (kuberne…
800ef77 
…tes-sigs#10390)

* [kubernetes] support 1.28.0/1.28.1 (kubernetes-sigs#10376)

* [kubernetes] Make 1.28.1 default (kubernetes-sigs#10376)
Alvaro-Campesino pushed a commit to Alvaro-Campesino/kubespray that referenced this pull request Nov 3, 2023
@tmurakam @Alvaro-Campesino
[kubernetes] support 1.28.0 / 1.28.1 (kubernetes-sigs#10376) (kuberne…
c92c3b3 
…tes-sigs#10390)

* [kubernetes] support 1.28.0/1.28.1 (kubernetes-sigs#10376)

* [kubernetes] Make 1.28.1 default (kubernetes-sigs#10376)
Alvaro-Campesino pushed a commit to Alvaro-Campesino/kubespray that referenced this pull request Nov 3, 2023
@tmurakam @Alvaro-Campesino
[kubernetes] support 1.28.0 / 1.28.1 (kubernetes-sigs#10376) (kuberne…
706b49c 
…tes-sigs#10390)

* [kubernetes] support 1.28.0/1.28.1 (kubernetes-sigs#10376)

* [kubernetes] Make 1.28.1 default (kubernetes-sigs#10376)
Alvaro-Campesino added a commit to Stratio/kubespray that referenced this pull request Nov 6, 2023
@Alvaro-Campesino @tmurakam
@mzaian @unai-ttxu
[EOS-12110] Update K8s version to v1.28.3 (#47)
0c7dec8 
* [kubernetes] support 1.28.0 / 1.28.1 (kubernetes-sigs#10376) (kubernetes-sigs#10390)

* [kubernetes] support 1.28.0/1.28.1 (kubernetes-sigs#10376)

* [kubernetes] Make 1.28.1 default (kubernetes-sigs#10376)

* [kubernetes] Add hashes for kubernetes 1.28.2, 1.27.6, 1.26.9 (kubernetes-sigs#10435)

* [kubernetes] Add hashes for kubernetes 1.28.3, 1.27.7, 1.26.10 (kubernetes-sigs#10541)

* Apply suggestions from code review

Co-authored-by: Unai Arríen <[email protected]>

---------

Co-authored-by: Takuya Murakami <[email protected]>
Co-authored-by: Mohamed Omar Zaian <[email protected]>
Co-authored-by: Unai Arríen <[email protected]>
@yankay yankay mentioned this pull request Dec 15, 2023
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@tmurakam @pedromcpedro
[kubernetes] support 1.28.0 / 1.28.1 (kubernetes-sigs#10376) (kuberne…
cb087d3 
…tes-sigs#10390)

* [kubernetes] support 1.28.0/1.28.1 (kubernetes-sigs#10376)

* [kubernetes] Make 1.28.1 default (kubernetes-sigs#10376)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@mzaian mzaian mzaian approved these changes

@bozzo bozzo Awaiting requested review from bozzo

@cyclinder cyclinder Awaiting requested review from cyclinder

Assignees

@mzaian mzaian

@yankay yankay

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubernetes 1.28 support
5 participants
@tmurakam @k8s-ci-robot @yankay @mzaian @floryut