Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of python script for checksum download #10335

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Improve performance of python script for checksum download #10335

merged 1 commit into from
Jan 23, 2024

Conversation

simon-wessel
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind cleanup

What this PR does / why we need it:
Instead of downloading all binaries for each arch and calculating the checksums for them, we just download the provided checksum for the respective binary directly (by adding a .sha256 suffix to the URL). This reduces the time from a few minutes to a few seconds.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 3, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 3, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: simon-wessel / name: Simon Wessel (849e524)

@k8s-ci-robot k8s-ci-robot requested a review from oomichi August 3, 2023 13:14
@k8s-ci-robot
Copy link
Contributor

Welcome @simon-wessel!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 3, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @simon-wessel. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 3, 2023
@simon-wessel
Copy link
Contributor Author

I adjusted my changes to #10121.

floryut
floryut approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simon-wessel Thank you for the PR
Could you please check CLA ?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, simon-wessel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2023
@yankay
Copy link
Member

yankay commented Aug 8, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 8, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 7, 2023
@simon-wessel
Copy link
Contributor Author

@floryut Done 👍

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2023
VannTen
VannTen requested changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@VannTen VannTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can rebase on master and change the checksums path (which has moved), I think this would be an interesting improvement :)

scripts/download_hash.py Outdated Show resolved Hide resolved
@simon-wessel simon-wessel force-pushed the download_hash_py_performance branch from 9c01fdc to a4a5bf3 Compare January 17, 2024 11:13
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2024
@VannTen
Copy link
Contributor

VannTen commented Jan 17, 2024

I think you can squash your commits (the whole change is pretty self-contained) and add a short explanation about the change in the commit message directly (mentionning in particular download hash instead of file + hashing)

@floryut
Copy link
Member

floryut commented Jan 23, 2024

@simon-wessel can you check @VannTen comment ? this could be merged as it's a nice improvement indeed 👍

@simon-wessel
chore: improve performance of python script for hash download
849e524 
The old version of the script downloaded all binaries and generated file checksums locally.
This was a slow process since all binaries of all architectures needed to be downloaded.
The new version simply downloads the .sha256 files containing the binary checksum in text
form which saves a lot of traffic and time.
@simon-wessel simon-wessel force-pushed the download_hash_py_performance branch from a4a5bf3 to 849e524 Compare January 23, 2024 13:48
@simon-wessel
Copy link
Contributor Author

@floryut @VannTen Does the new commit description work for you?

@VannTen
Copy link
Contributor

VannTen commented Jan 23, 2024

Perfect, thanks !
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0e26f6f into kubernetes-sigs:master Jan 23, 2024
65 checks passed
@floryut
Copy link
Member

floryut commented Jan 23, 2024

Thank you @simon-wessel

@mzaian mzaian mentioned this pull request Apr 26, 2024
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@simon-wessel @pedromcpedro
chore: improve performance of python script for hash download (kubern…
3b148a4 
…etes-sigs#10335)

The old version of the script downloaded all binaries and generated file checksums locally.
This was a slow process since all binaries of all architectures needed to be downloaded.
The new version simply downloads the .sha256 files containing the binary checksum in text
form which saves a lot of traffic and time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VannTen VannTen VannTen requested changes

@floryut floryut floryut approved these changes

@cristicalin cristicalin Awaiting requested review from cristicalin

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@VannTen VannTen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@simon-wessel @k8s-ci-robot @yankay @VannTen @floryut