Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #10308

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Update README #10308

merged 1 commit into from
Jul 25, 2023

Conversation

0ekk
Copy link
Member

@0ekk 0ekk commented Jul 24, 2023 •
edited
Loading

What type of PR is this?

/kind documentation

What this PR does / why we need it:

  • update minimal ansible version to v2.14+
  • update supported list of docker versions

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 24, 2023
@k8s-ci-robot k8s-ci-robot requested review from holmsten and yankay July 24, 2023 07:22
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 24, 2023
@0ekk
Update README
8be2955 
update minimal ansible version to v2.14+

update supported list of docker versions

Signed-off-by: tu1h <[email protected]>
MrFreezeex
MrFreezeex approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2023
@yankay
Copy link
Member

yankay commented Jul 25, 2023

Thanks @tu1h
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, tu1h, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit f2bb3ab into kubernetes-sigs:master Jul 25, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@0ekk @pedromcpedro
Update README (kubernetes-sigs#10308)
2d7297f 
update minimal ansible version to v2.14+

update supported list of docker versions

Signed-off-by: tu1h <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrFreezeex MrFreezeex MrFreezeex approved these changes

@holmsten holmsten Awaiting requested review from holmsten

@yankay yankay Awaiting requested review from yankay

Assignees

@MrFreezeex MrFreezeex

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0ekk @yankay @k8s-ci-robot @MrFreezeex