Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve security with CIS Kubernetes V1.23 Benchmark item number 4.1.9 #10304

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

satandyh
Copy link
Contributor

@satandyh satandyh commented Jul 20, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Improve security with CIS Kubernetes V1.23 Benchmark item number 4.1.9
Ref to https://github.com/aquasecurity/kube-bench/blob/main/cfg/cis-1.23/node.yaml#L131

Also because there present additional config file kubelet.env. It's permissions also changed to the same as for kubelet-config.yaml.

Which issue(s) this PR fixes:

Fixes #10302

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix CIS Kubernetes V1.23 Benchmark item number 4.1.9 to enhance security (Change kubelet-config.yaml and kubelet.env file permissions from 640 to 600)

Benchmark item number 4.1.9
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 20, 2023
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 20, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @satandyh!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 20, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @satandyh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 20, 2023
@MrFreezeex
Copy link
Member

Hi could you check what's up with the cla? It appear that the email address you are using to commit is not on your GitHub profile.

@yankay
Copy link
Member

yankay commented Jul 21, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 21, 2023
@satandyh
Copy link
Contributor Author

Hi could you check what's up with the cla? It appear that the email address you are using to commit is not on your GitHub profile.

Hello, @MrFreezeex
yep I missed it to add to GitHub, my fault. Because I often use more than one laptop with different configurations. I have added my email from the PR to my GitHub account. Check the proof in the link below (it's png image on google drive). Let me know if I need to perform any additional steps.

https://drive.google.com/file/d/1LaAdS8EhXj8h0yixXpkAZwigMthWEiGS/view?usp=sharing

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 21, 2023
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's not really that I need a proof or anything but the CI will not be able to merge your PR if it has not the label. Anyway thanks for fixing it :D.
/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2023
@yankay
Copy link
Member

yankay commented Jul 24, 2023

@satandyh Thanks

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, satandyh, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 050bd05 into kubernetes-sigs:master Jul 24, 2023
@yankay yankay mentioned this pull request Aug 24, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve security with CIS Kubernetes V1.23 Benchmark item number 4.1.9
4 participants