-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve security with CIS Kubernetes V1.23 Benchmark item number 4.1.9 #10304
Conversation
Benchmark item number 4.1.9
|
Welcome @satandyh! |
Hi @satandyh. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi could you check what's up with the cla? It appear that the email address you are using to commit is not on your GitHub profile. |
/ok-to-test |
Hello, @MrFreezeex https://drive.google.com/file/d/1LaAdS8EhXj8h0yixXpkAZwigMthWEiGS/view?usp=sharing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It's not really that I need a proof or anything but the CI will not be able to merge your PR if it has not the label. Anyway thanks for fixing it :D.
/lgtm
/ok-to-test
@satandyh Thanks /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrFreezeex, satandyh, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Benchmark item number 4.1.9
What type of PR is this?
/kind feature
What this PR does / why we need it:
Improve security with CIS Kubernetes V1.23 Benchmark item number 4.1.9
Ref to https://github.com/aquasecurity/kube-bench/blob/main/cfg/cis-1.23/node.yaml#L131
Also because there present additional config file
kubelet.env
. It's permissions also changed to the same as forkubelet-config.yaml
.Which issue(s) this PR fixes:
Fixes #10302
Special notes for your reviewer:
Does this PR introduce a user-facing change?: