-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix etcdctl copy operation #10230
Fix etcdctl copy operation #10230
Conversation
Signed-off-by: bo.jiang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ErikJiang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always thought that docker cp
needed tar as well, like kubectl
does, but it does not, TIL! Thanks for the nice fix :D
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ErikJiang, MrFreezeex, mzaian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @ErikJiang nerctl not support crio and not installed if I try and get error. container_manager: crio
etcd_deployment_type: kubeadm
|
Signed-off-by: bo.jiang <[email protected]>
Signed-off-by: bo.jiang <[email protected]>
What type of PR is this?
/kind bug
What this PR does / why we need it:
The distroless base image is used in the
v3.5.7
version of the etcd image, for details see: etcd-io/etcd#15016This means that the previous copy command for
etcdctl
will no longer work.Which issue(s) this PR fixes:
Fixes #10229
Special notes for your reviewer:
Does this PR introduce a user-facing change?: