Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix etcdctl copy operation #10230

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Fix etcdctl copy operation #10230

merged 1 commit into from
Jun 16, 2023

Conversation

ErikJiang
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:

The distroless base image is used in the v3.5.7 version of the etcd image, for details see: etcd-io/etcd#15016

This means that the previous copy command for etcdctl will no longer work.

Which issue(s) this PR fixes:

Fixes #10229

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix etcdctl copy operation

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 16, 2023
@k8s-ci-robot k8s-ci-robot requested review from EppO and liupeng0518 June 16, 2023 07:39
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 16, 2023
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ErikJiang

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2023
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always thought that docker cp needed tar as well, like kubectl does, but it does not, TIL! Thanks for the nice fix :D
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ErikJiang, MrFreezeex, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 54859cb into kubernetes-sigs:master Jun 16, 2023
@yckaolalala
Copy link
Contributor

Hi @ErikJiang

nerctl not support crio and not installed if container_manager is crio

I try and get error.

container_manager: crio
etcd_deployment_type: kubeadm
TASK [etcdctl : Copy etcdctl script to host] *****************************************************************************************************************
fatal: [k8s-192-168-57-17]: FAILED! => {"changed": true, "cmd": "/usr/local/bin/nerdctl cp \"$(/usr/local/bin/crictl ps -q --image quay.io/coreos/etcd:v3.5.6)\":/usr/local/bin/etcdctl /var/lib/etcd/etcdctl", "delta": "0:00:00.038258", "end": "2023-06-20 06:44:37.852183", "msg": "non-zero return code", "rc": 127, "start": "2023-06-20 06:44:37.813925", "stderr": "/bin/sh: /usr/local/bin/nerdctl: No such file or directory", "stderr_lines": ["/bin/sh: /usr/local/bin/nerdctl: No such file or directory"], "stdout": "", "stdout_lines": []}

maciej-markowski pushed a commit to maciej-markowski/kubespray that referenced this pull request Jun 23, 2023
@yankay yankay mentioned this pull request Aug 24, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

etcdctl copy operation failed
5 participants