Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump coredns version to 1.10.1 #10199

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

eminaktas
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind feature

What this PR does / why we need it:

bumps coredns default version to 1.10.1

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

bump coredns version to 1.10.1

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 8, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @eminaktas. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 8, 2023
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eminaktas Thank you!
I'm putting a hold, as we might want to wait for 1.27 switch, WDYT ?
On the other hand as long as CI works, no need to wait I guess.

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 8, 2023
@eminaktas
Copy link
Contributor Author

eminaktas commented Jun 8, 2023

@eminaktas Thank you! I'm putting a hold, as we might want to wait for 1.27 switch, WDYT ? On the other hand as long as CI works, no need to wait I guess.

/hold

Thanks. CI failed :(. I'll take a look 👍

@eminaktas
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@eminaktas: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eminaktas eminaktas force-pushed the coredns-1-10-1 branch 3 times, most recently from d77fe2e to 4af8bd9 Compare June 8, 2023 16:11
@eminaktas
Copy link
Contributor Author

When I checked the logs nodelocaldns was not able to reach coredns.

[ERROR] plugin/errors: 2 netchecker-service.cluster.local. AAAA: dial tcp 10.233.0.3:53: connect: connection refused
[ERROR] plugin/errors: 2 netchecker-service.cluster.local. A: dial tcp 10.233.0.3:53: connect: connection refused
[ERROR] plugin/errors: 2 netchecker-service.cluster.local. AAAA: dial tcp 10.233.0.3:53: connect: connection refused
[ERROR] plugin/errors: 2 netchecker-service.894123319-4440306518.svc.cluster.local. A: dial tcp 10.233.0.3:53: connect: connection refused
[ERROR] plugin/errors: 2 netchecker-service.894123319-4440306518.svc.cluster.local. AAAA: dial tcp 10.233.0.3:53: connect: connection refused
[ERROR] plugin/errors: 2 netchecker-service.894123319-4440306518.svc.cluster.local. A: dial tcp 10.233.0.3:53: connect: connection refused
[ERROR] plugin/errors: 2 netchecker-service.894123319-4440306518.svc.cluster.local. AAAA: dial tcp 10.233.0.3:53: connect: connection refused

However, coredns pods look healthy and in the running state.

TASK [Check connectivity with all netchecker agents] ***************************
task path: /builds/kargo-ci/kubernetes-sigs-kubespray/tests/testcases/040_check-network-adv.yml:157
Thursday 08 June 2023  18:10:04 +0000 (0:00:00.199)       0:03:20.301 ********* 
fatal: [instance-2 -> instance-1(172.30.76.118)]: FAILED! => {
    "assertion": "agents_check_result is defined",
    "changed": false,
    "evaluated_to": false,
    "msg": "Connectivity check to netchecker agents failed"
}

@yankay
Copy link
Member

yankay commented Jun 15, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 15, 2023
@eminaktas
Copy link
Contributor Author

Hey @floryut, I think it is ok to merge now. 👀

@floryut
Copy link
Member

floryut commented Jun 19, 2023

Hey @floryut, I think it is ok to merge now. 👀

Fine for me, as long as someone lgtm this
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2023
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 👍!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eminaktas, floryut, MrFreezeex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 79e742c into kubernetes-sigs:master Jun 19, 2023
maciej-markowski pushed a commit to maciej-markowski/kubespray that referenced this pull request Jun 23, 2023
@yankay yankay mentioned this pull request Aug 24, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants