Fix metrics-server for k8s 1.26 #10183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mzaian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Thanks for testing this locally :-) /lgtm |
k8s-ci-robot
added
the
lgtm
yankay
pushed a commit
to yankay/kubespray
that referenced
this pull request
Jun 5, 2023
k8s-ci-robot
pushed a commit
that referenced
this pull request
Jun 5, 2023
Co-authored-by: Mohamed Omar Zaian <[email protected]>
pedro-peter
pushed a commit
to pedro-peter/kubespray
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Set
--kubelet-insecure-tlsto--kubelet-insecure-tls=trueto fix metrics-server deploymentI also checked this version against older version of kubernetes '1.24.x' and it works fine.
Also see: kubernetes-sigs/metrics-server#1266
Which issue(s) this PR fixes:
Fixes #10178
Does this PR introduce a user-facing change?: