Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubelet csr approver fixes #10165

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Kubelet csr approver fixes #10165

merged 2 commits into from
Jun 6, 2023

Conversation

j4m3s-s
Copy link
Contributor

@j4m3s-s j4m3s-s commented May 31, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

  • Fixes role helm by installing missing package
  • Fix hanging issue when upgrading with newly enabled kubelet-csr-approver
    Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix kubelet-csr-approver usage with upgrade-cluster.yml and missing package with helm role

@j4m3s-s
Fix upgrade-path for kubelet-csr-approver
148ff26 
Fixes an error when you enable kubelet-csr-approver when upgrading.
It hangs waiting for the certificate to be approved since the
kubelet-csr-approver is not installed yet.
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 31, 2023
@k8s-ci-robot k8s-ci-robot requested review from EppO and MrFreezeex May 31, 2023 13:07
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 31, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @j4m3s-s. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 31, 2023
@j4m3s-s j4m3s-s force-pushed the kubelet-csr-approver-fixes branch from 1e1f9d8 to ee4c666 Compare May 31, 2023 13:31
@j4m3s-s j4m3s-s force-pushed the kubelet-csr-approver-fixes branch 2 times, most recently from dd59c78 to f5516c5 Compare June 1, 2023 09:02
@j4m3s-s
Copy link
Contributor Author

j4m3s-s commented Jun 1, 2023

CI has passed (see https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/4386095461), I've removed the WIP testing commit.

MrFreezeex
MrFreezeex approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these nice fixes :D
/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 1, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2023
This was referenced Jun 6, 2023
Merged
Closed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: j4m3s-s, MrFreezeex, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4c76feb into kubernetes-sigs:master Jun 6, 2023
palmeXx pushed a commit to palmeXx/kubespray that referenced this pull request Jun 7, 2023
@j4m3s-s @palmeXx
Kubelet csr approver fixes (kubernetes-sigs#10165)
72601af 
* Fix upgrade-path for kubelet-csr-approver

Fixes an error when you enable kubelet-csr-approver when upgrading.
It hangs waiting for the certificate to be approved since the
kubelet-csr-approver is not installed yet.

* Add missing package when using helm role
maciej-markowski pushed a commit to maciej-markowski/kubespray that referenced this pull request Jun 23, 2023
@j4m3s-s @maciej-markowski
Kubelet csr approver fixes (kubernetes-sigs#10165)
1c98745 
* Fix upgrade-path for kubelet-csr-approver

Fixes an error when you enable kubelet-csr-approver when upgrading.
It hangs waiting for the certificate to be approved since the
kubelet-csr-approver is not installed yet.

* Add missing package when using helm role
@yankay yankay mentioned this pull request Aug 24, 2023
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@j4m3s-s @pedromcpedro
Kubelet csr approver fixes (kubernetes-sigs#10165)
08a4d5e 
* Fix upgrade-path for kubelet-csr-approver

Fixes an error when you enable kubelet-csr-approver when upgrading.
It hangs waiting for the certificate to be approved since the
kubelet-csr-approver is not installed yet.

* Add missing package when using helm role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrFreezeex MrFreezeex MrFreezeex approved these changes

@mzaian mzaian mzaian approved these changes

@EppO EppO Awaiting requested review from EppO

Assignees

@mzaian mzaian

@MrFreezeex MrFreezeex

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@j4m3s-s @k8s-ci-robot @mzaian @MrFreezeex