-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't create calico CNI dir when not using calico #10156
Don't create calico CNI dir when not using calico #10156
Conversation
Hi @jcpunk. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
db2412a
to
d17d311
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me however the CI failed and it tends to do that whenever there is a lot of tasks running :(. So you might try again in a little while or tomorrow either by rebasing or amend your commit + push force.
/lgtm
/ok-to-test
Signed-off-by: Pat Riehecky <[email protected]>
d17d311
to
f074bc2
Compare
Rebased |
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jcpunk Thank you 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, jcpunk, MrFreezeex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
) Signed-off-by: Pat Riehecky <[email protected]>
) Signed-off-by: Pat Riehecky <[email protected]>
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The calico CNI directory is calico specific and shouldn't be loaded for other CNI types.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: