Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels to kube-vip static pods #10139

Conversation

liupeng0518
Copy link
Member

@liupeng0518 liupeng0518 commented May 26, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Add labels to kube-vip static pods

Which issue(s) this PR fixes:

Fixes #10110

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add labels to kube-vip static pods

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 26, 2023
@k8s-ci-robot k8s-ci-robot requested review from bozzo and cyclinder May 26, 2023 03:35
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 26, 2023
@oomichi
Copy link
Contributor

oomichi commented May 29, 2023

Please rebase this pull request on the latest master branch to solve tf-elastx_cleanup issue.

@liupeng0518 liupeng0518 force-pushed the Add-labels-to-kube-vip-static-pods branch from cca482b to 5b2c2e4 Compare May 30, 2023 01:20
@oomichi
Copy link
Contributor

oomichi commented Jun 1, 2023

/retest

@liupeng0518 liupeng0518 requested a review from MrFreezeex June 1, 2023 09:19
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks still good (well no real change :p), but I guess it needs another approval :p

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liupeng0518, MrFreezeex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oomichi
Copy link
Contributor

oomichi commented Jun 1, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit d7b7939 into kubernetes-sigs:master Jun 1, 2023
@floryut floryut added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 8, 2023
alekseyolg pushed a commit to alekseyolg/kubespray that referenced this pull request Jun 21, 2023
@yankay yankay mentioned this pull request Aug 24, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add labels to kube-vip static pods
5 participants