-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix problem migration to k8s 1.27 #10136
Conversation
|
Welcome @batazor! |
Hi @batazor. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@MrFreezeex Are you about this MR #9976? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my bad, I didn't catch this one!
/lgtm
/ok-to-test
The task includes an option with an undefined variable
for 1.27Signed-off-by: Victor Login <[email protected]>
So, I got a working k8s cluster:
|
Thanks for this very nice contribution 👍 |
I used the same changes to upgrade my cluster to 1.27. LGTM. |
Thanks for doing this. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: batazor, MrFreezeex, oomichi, starcraft66 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Fix `The task includes an option with an undefined variable` for 1.27 * delete old flag --container-runtime Signed-off-by: Victor Login <[email protected]> --------- Signed-off-by: Victor Login <[email protected]>
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
snapshot_controller_supported_versions
--container-runtime
cleanup container runtime options kubernetes/kubernetes#114017Special notes for your reviewer:
Does this PR introduce a user-facing change?: