Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metallb fix #10135

Closed
wants to merge 11 commits into from
Closed

Metallb fix #10135

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6c19271
Fixing Metallb template discrepancy
Taranasaur May 25, 2023
b99f0c8
Merge branch 'kubernetes-sigs:master' into metallb-fix
Taranasaur May 25, 2023
f59a998
Merge branch 'kubernetes-sigs:master' into metallb-fix
Taranasaur May 25, 2023
dc7051c
Update metallb.yml.j2
Taranasaur May 25, 2023
8169d7f
Update main.yml
Taranasaur May 25, 2023
7d2b362
Update metallb.yml.j2
Taranasaur May 25, 2023
e1eabbf
Update packet_centos7-flannel-addons-ha.yml
Taranasaur May 26, 2023
f57f31c
Merge branch 'kubernetes-sigs:master' into metallb-fix
Taranasaur May 26, 2023
63ecb39
Update main.yml
Taranasaur May 26, 2023
9d0dc77
Merge branch 'kubernetes-sigs:master' into metallb-fix
Taranasaur May 26, 2023
b3b5b7b
Update metallb.yml.j2
Taranasaur May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions roles/kubernetes-apps/metallb/templates/metallb.yml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
apiVersion: v1
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the namespace creation at the top of this manifest.. could not see it being created in any other task

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a mega nit could you add the document delimiter --- at the beginning of the file?

kind: Namespace
metadata:
name: metallb-system
labels:
app: metallb
---
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
Expand Down