Update download_hash.sh script #10120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
Merged
k8s-ci-robot
added
the
needs-rebase
electrocucaracha
force-pushed
the
update_download_hash_script
branch
from
3f82440 to
ecfec39
Compare
k8s-ci-robot
removed
the
needs-rebase
yankay
reviewed
May 26, 2023
| for arch in arm64 amd64 ppc64le; do | ||
| echo " $arch:" | tee --append "$checksums_file" | ||
| for version in "${@:2}"; do | ||
| echo " ${version#v}: $(_get_checksum "$binary" "$version" "$arch")" | tee --append "$checksums_file" |
There was a problem hiding this comment.
HI @electrocucaracha
It makes kubespray can not install in offline environments.
There was a problem hiding this comment.
The purpose of this script is to facilitate the maintenance tasks, that means it's going to be used once in a while to collect checksums and submit PR with the latest values. This is not pretend to be used during execution
MrFreezeex
reviewed
May 26, 2023
electrocucaracha
force-pushed
the
update_download_hash_script
branch
from
ecfec39 to
cf84eb0
Compare
k8s-ci-robot
added
size/S
electrocucaracha
force-pushed
the
update_download_hash_script
branch
from
cf84eb0 to
8302a97
Compare
|
Thanks! :D |
k8s-ci-robot
added
the
lgtm
floryut
approved these changes
Jun 19, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: electrocucaracha, floryut The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
floryut
added
kind/feature
maciej-markowski
pushed a commit
to maciej-markowski/kubespray
that referenced
this pull request
Jun 23, 2023
pedro-peter
pushed a commit
to pedro-peter/kubespray
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This change updates the URL used to download the Kubernetes binaries as well as creates a function to manage the collection of CRI-O hashes
Which issue(s) this PR fixes:
NA
Special notes for your reviewer:
Does this PR introduce a user-facing change?: