-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated crio_pids_limit #10056
Conversation
Hi @j4m3s-s. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this nice cleanup :D
/ok-to-test
/lgtm
/lgtm |
/lgtm |
Hi @j4m3s-s can you rebase your PR again? I believe the CI issues should be fixed now... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@j4m3s-s Thank you 🙇
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, j4m3s-s, MrFreezeex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1f2f888
to
af29c80
Compare
As per cri-o/cri-o#5831, option is now deprecated.
/lgtm |
As per cri-o/cri-o#5831, option is now deprecated.
What type of PR is this?
What this PR does / why we need it:
Remove deprecated crio_pids_limit as per cri-o/cri-o#5831
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: