Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solves #2933: Allow http_proxy, https_proxy and no_proxy environment variables in cert-manager playbook #10035

Closed
wants to merge 0 commits into from
Closed

Solves #2933: Allow http_proxy, https_proxy and no_proxy environment variables in cert-manager playbook #10035

wants to merge 0 commits into from

Conversation

karabanov
Copy link
Contributor

@karabanov karabanov commented Apr 29, 2023 •
edited
Loading

Allow http_proxy, https_proxy and no_proxy environment variables in cert-manager playbook

What type of PR is this?
/kind feature

What this PR does / why we need it:
Allows to get TLS certificates if the cluster is located in a closed circuit with access to the Internet only through a proxy

Which issue(s) this PR fixes:
Fixes #2933

Special notes for your reviewer:
No notes

Does this PR introduce a user-facing change?:
NONE

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 29, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 29, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: karabanov / name: Aleksandr Karabanov (9e3eac5)

@k8s-ci-robot
Copy link
Contributor

Welcome @karabanov!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 29, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @karabanov. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 29, 2023
@k8s-ci-robot k8s-ci-robot requested review from cyclinder and EppO April 29, 2023 11:43
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 29, 2023
MrFreezeex
MrFreezeex suggested changes May 22, 2023
View reviewed changes
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! A couple of nits and a small typo but lgtm overall, thanks again :).

Also please rebase your PR 🙏 and also can you rename your PR like your title and perhaps link the issue in the commit description if you want keep a link to it.

roles/kubernetes-apps/ingress_controller/cert_manager/defaults/main.yml Outdated
@@ -7,6 +7,12 @@ cert_manager_nodeselector: {}
cert_manager_dns_policy: "ClusterFirst"
cert_manager_dns_config: {}

## Allow http_proxy, https_proxy and no_proxy environment variables
## Issue https://github.com/kubernetes-sigs/kubespray/issues/2933
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this line? IMO linking to the issue doesn't add much value here...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. I will remove this line

roles/kubernetes-apps/ingress_controller/cert_manager/templates/cert-manager.yml.j2 Outdated
- name: HTTPS_PROXY
value: "{{ cert_manager_https_proxy }}"
{% endif %}
{% if cert_manager_no_proxy is cert_manager_no_proxy != "" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guessing that you missed is defined and here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake. I will fix it.

roles/kubernetes-apps/ingress_controller/cert_manager/defaults/main.yml Outdated
## Details https://github.com/kubernetes-sigs/kubespray/blob/master/docs/proxy.md
cert_manager_http_proxy: "{{ http_proxy|d('') }}"
cert_manager_https_proxy: "{{ https_proxy|d('') }}"
cert_manager_no_proxy: "{{ no_proxy|d('') }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nit but style wise I think we prefer to use default rather than just d

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll change it to default

@karabanov karabanov marked this pull request as draft May 27, 2023 12:02
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2023
@karabanov karabanov changed the title Allow http proxy environment variables in cert-manager playbook Solves #2933: Allow http_proxy, https_proxy and no_proxy environment variables in cert-manager playbook May 27, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 27, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: karabanov / name: Aleksandr Karabanov (fe858a6)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 27, 2023
@karabanov karabanov requested a review from MrFreezeex May 27, 2023 12:53
@karabanov karabanov marked this pull request as ready for review May 27, 2023 12:54
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2023
@k8s-ci-robot k8s-ci-robot requested review from oomichi and yankay May 27, 2023 12:54
@MrFreezeex
Copy link
Member

Looks good to me however, could you rebase to rekick the pipeline?

@karabanov karabanov closed this May 30, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: karabanov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyclinder cyclinder Awaiting requested review from cyclinder

@EppO EppO Awaiting requested review from EppO

@MrFreezeex MrFreezeex Awaiting requested review from MrFreezeex

@oomichi oomichi Awaiting requested review from oomichi

@yankay yankay Awaiting requested review from yankay

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow http_proxy environment variables for cert-manager
3 participants
@karabanov @k8s-ci-robot @MrFreezeex