Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APT Package Installation Improvements #2284

Closed
jasdeep-hundal opened this issue Feb 9, 2018 · 5 comments
Closed

APT Package Installation Improvements #2284

jasdeep-hundal opened this issue Feb 9, 2018 · 5 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@jasdeep-hundal
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST? (choose one): FEATURE REQUEST

Proposing two improvements around APT package installation:

  1. Removing the explicit install of the python-apt package during preinstall:

    • The Ansible 'apt' module actually lists 'python-apt' as a dependency, so we wouldn't expect this to work anyways.
    • The reason it does is that Ansible automatically installs python-apt upon the first usage of the "apt" module.
    • Will have patch up for this shortly.
  2. Adding the ability to skip APT package management cache updates:

    • Two use cases on my end:
      • Being able to test deployment offline.
      • Increasing idempotence when debugging deployment issues. Even though the risk of package updates breaking something is small, would rather totally rule that out when investigating.
    • I can add a two line hack to get around this, would be nice if there was a clean option though.
    • Happy to work on a patch for this as well, but that might be delayed for a bit. Also, I'm guessing we don't want divergence between APT and YUM behavior, so:
      • Slightly worried about testing against Yum because I haven't run Kubespray against a system using it yet.
      • Will probably need a bit more back and forth with Kubespray devs before settling on the right way to do this.
@jasdeep-hundal
Copy link
Contributor Author

Patch for the first request is here: #2285

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 10, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 10, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants