preinstall task tries to remove entry from non-existing fstab on fedora core

[vesnikos]

Task 0010-swapoff.yml is trying to remove swap entry from /etc/fstab file as seen bellow. Fedora Core afik does not ship with a /etc/fstab causing the task to fail

Mitigation is easy; either a when: not "{{ is_fedora_core | bool }}" entry or ignore_errors: true to the task

kubespray/roles/kubernetes/preinstall/tasks/0010-swapoff.yml

Lines 2 to 9 in edff3f8

	- name: Remove swapfile from /etc/fstab
	ansible.posix.mount:
	name: "{{ item }}"
	fstype: swap
	state: absent
	loop:
	- swap
	- none

[VannTen]

I assume you meant Fedora Coreos ?

[vesnikos]

I assume you meant Fedora Coreos ?

yes; fedora coreos.
Nodes were provisioned using vhdx's for hyper-v.

Without being an authoritive figure on it, fcos favours .mount systemd units as described (or hinted) at their storage documentation

[VannTen]

On Fri, Nov 03, 2023 at 01:37:56AM -0700, Nikos Ves wrote: > I assume you meant Fedora Coreos ? yes; fedora coreos. Nodes were provisioned using vhdx's for hyper-v. Without being an authoritive figure on it, fcos favours .mount systemd units as described (or hinted) at their storage [documentation](https://docs.fedoraproject.org/en-US/fedora-coreos/storage/#_adding_network_storage)

For swap devices (partition or files) there is systemd .swap units. To disable swap on any systemd-managed distribution we could probably simply mask the swap.target.

[vesnikos]

Makes sense that the swapoff task to act accordingly if it's systemd-managed distribution or not. Soft failing if fstab is absent does not guarantee that there's no swap enabled whatsoever. in this case not having a swap it was a side effect of the node provision process (ie I hadn't defined any swap on the provision script). In a relevant note, but I haven't seen a `is_systemd_managed` fact or something similar defined so far. Only a `is_fedora_core` fact so far; but pretty new to kubespray, so might have missed something.

________________________________________ From: Max Gautier ***@***.***> Sent: 03 November 2023 09:02 To: kubernetes-sigs/kubespray Cc: Nick Ves; Author

Subject: Re: [kubernetes-sigs/kubespray] preinstall task tries to remove entry from non-existing fstab on fedora core (Issue #10581) On Fri, Nov 03, 2023 at 01:37:56AM -0700, Nikos Ves wrote: > I assume you meant Fedora Coreos ? yes; fedora coreos. Nodes were provisioned using vhdx's for hyper-v. Without being an authoritive figure on it, fcos favours .mount systemd units as described (or hinted) at their storage [documentation](https://docs.fedoraproject.org/en-US/fedora-coreos/storage/#_adding_network_storage)

For swap devices (partition or files) there is systemd .swap units. To disable swap on any systemd-managed distribution we could probably simply mask the swap.target. — Reply to this email directly, view it on GitHub<#10581 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABS74EWRE2XRTV6YFQWQON3YCSXI3AVCNFSM6AAAAAA6ZIBIBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJSGA3TQMBRGE>. You are receiving this because you authored the thread.Message ID: ***@***.***>