project: replace unnamed-task by name[missing]

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>

roles/container-engine/docker/tasks/main.yml

@@ -143,7 +143,7 @@
         state: started
       when: docker_task_result is not changed
   rescue:
-    - debug:  # noqa unnamed-task
+    - debug:  # noqa name[missing]
         msg: "Docker start failed. Try to remove our config"
     - name: remove kubespray generated config
       file:

roles/download/tasks/download_container.yml

@@ -18,7 +18,7 @@
       when:
         - not download_always_pull
 
-    - debug:  # noqa unnamed-task
+    - debug:  # noqa name[missing]
         msg: "Pull {{ image_reponame }} required is: {{ pull_required }}"
 
     - name: download_container | Determine if image is in cache

roles/kubernetes/node-label/tasks/main.yml

@@ -35,9 +35,9 @@
     - node_labels is defined
     - node_labels is mapping
 
-- debug:  # noqa unnamed-task
+- debug:  # noqa name[missing]
     var: role_node_labels
-- debug:  # noqa unnamed-task
+- debug:  # noqa name[missing]
     var: inventory_node_labels
 
 - name: Set label to node

roles/win_nodes/kubernetes_patch/tasks/main.yml

@@ -29,11 +29,11 @@
       register: patch_kube_proxy_state
       when: current_kube_proxy_state.stdout | trim | lower != "linux"
 
-    - debug:  # noqa unnamed-task
+    - debug:  # noqa name[missing]
         msg: "{{ patch_kube_proxy_state.stdout_lines }}"
       when: patch_kube_proxy_state is not skipped
 
-    - debug:  # noqa unnamed-task
+    - debug:  # noqa name[missing]
         msg: "{{ patch_kube_proxy_state.stderr_lines }}"
       when: patch_kube_proxy_state is not skipped
   tags: init

tests/cloud_playbooks/create-aws.yml

@@ -20,6 +20,6 @@
 
   - name: Template the inventory
     template:
-      src: ../templates/inventory-aws.j2  # noqa 404 CI inventory templates are not in role_path
+      src: ../templates/inventory-aws.j2  # noqa no-relative-paths - CI inventory templates are not in role_path
       dest: "{{ inventory_path }}"
       mode: 0644

tests/cloud_playbooks/create-do.yml

@@ -80,13 +80,13 @@
       register: droplets
       with_items: "{{ instance_names }}"
 
-    - debug:  # noqa unnamed-task
+    - debug:  # noqa name[missing]
         msg: "{{ droplets }}, {{ inventory_path }}"
       when: state == 'present'
 
     - name: Template the inventory
       template:
-        src: ../templates/inventory-do.j2  # noqa 404 CI templates are not in role_path
+        src: ../templates/inventory-do.j2  # noqa no-relative-paths - CI templates are not in role_path
         dest: "{{ inventory_path }}"
         mode: 0644
       when: state == 'present'

tests/cloud_playbooks/create-gce.yml

@@ -51,7 +51,7 @@
         groupname: "waitfor_hosts"
       with_items: '{{ gce.instance_data }}'
 
-    - name: Template the inventory  # noqa 404 CI inventory templates are not in role_path
+    - name: Template the inventory  # noqa no-relative-paths - CI inventory templates are not in role_path
       template:
         src: ../templates/inventory-gce.j2
         dest: "{{ inventory_path }}"
@@ -64,7 +64,7 @@
         mode: 0755
       when: mode in ['scale', 'separate-scale', 'ha-scale']
 
-    - name: Template fake hosts group vars  # noqa 404 CI templates are not in role_path
+    - name: Template fake hosts group vars  # noqa no-relative-paths - CI templates are not in role_path
       template:
         src: ../templates/fake_hosts.yml.j2
         dest: "{{ inventory_path|dirname }}/group_vars/fake_hosts.yml"

tests/cloud_playbooks/upload-logs-gcs.yml

@@ -77,5 +77,5 @@
       failed_when: false
       no_log: True
 
-    - debug:  # noqa unnamed-task
+    - debug:  # noqa name[missing]
         msg: "A public url https://storage.googleapis.com/{{ test_name }}/{{ file_name }}"

tests/testcases/010_check-apiserver.yml

@@ -12,7 +12,7 @@
     delay: 5
     until: apiserver_response is success
 
-  - debug:  # noqa unnamed-task
+  - debug:  # noqa name[missing]
       msg: "{{ apiserver_response.json }}"
 
   - name: Check API servers version

tests/testcases/015_check-nodes-ready.yml

@@ -12,7 +12,7 @@
       bin_dir: "/usr/local/bin"
     when: not ansible_os_family in ["Flatcar", "Flatcar Container Linux by Kinvolk"]
 
-  - import_role:  # noqa unnamed-task
+  - import_role:  # noqa name[missing]
       name: cluster-dump
 
   - name: Check kubectl output
@@ -21,7 +21,7 @@
     register: get_nodes
     no_log: true
 
-  - debug:  # noqa unnamed-task
+  - debug:  # noqa name[missing]
       msg: "{{ get_nodes.stdout.split('\n') }}"
 
   - name: Check that all nodes are running and ready

tests/testcases/020_check-pods-running.yml

@@ -12,7 +12,7 @@
       bin_dir: "/usr/local/bin"
     when: not ansible_os_family in ["Flatcar", "Flatcar Container Linux by Kinvolk"]
 
-  - import_role:  # noqa unnamed-task
+  - import_role:  # noqa name[missing]
       name: cluster-dump
 
   - name: Check kubectl output
@@ -21,7 +21,7 @@
     register: get_pods
     no_log: true
 
-  - debug:  # noqa unnamed-task
+  - debug:  # noqa name[missing]
       msg: "{{ get_pods.stdout.split('\n') }}"
 
   - name: Check that all pods are running and ready
@@ -44,6 +44,6 @@
     register: get_pods
     no_log: true
 
-  - debug:  # noqa unnamed-task
+  - debug:  # noqa name[missing]
       msg: "{{ get_pods.stdout.split('\n') }}"
     failed_when: not run_pods_log is success

tests/testcases/030_check-network.yml

@@ -23,7 +23,7 @@
       register: get_csr
       changed_when: false
 
-    - debug:  # noqa unnamed-task
+    - debug:  # noqa name[missing]
         msg: "{{ get_csr.stdout.split('\n') }}"
 
     - name: Check there are csrs
@@ -63,7 +63,7 @@
       when: get_csr.stdout_lines | length > 0
       changed_when: certificate_approve.stdout
 
-    - debug:  # noqa unnamed-task
+    - debug:  # noqa name[missing]
         msg: "{{ certificate_approve.stdout.split('\n') }}"
 
     when:
@@ -114,7 +114,7 @@
     - agnhost1
     - agnhost2
 
-  - import_role:  # noqa unnamed-task
+  - import_role:  # noqa name[missing]
       name: cluster-dump
 
   - name: Check that all pods are running and ready
@@ -137,7 +137,7 @@
     register: pods
     no_log: true
 
-  - debug:  # noqa unnamed-task
+  - debug:  # noqa name[missing]
       msg: "{{ pods.stdout.split('\n') }}"
     failed_when: not run_pods_log is success
 
@@ -162,7 +162,7 @@
     register: get_pods
     no_log: true
 
-  - debug:  # noqa unnamed-task
+  - debug:  # noqa name[missing]
       msg: "{{ get_pods.stdout.split('\n') }}"
 
   - name: Set networking facts

tests/testcases/040_check-network-adv.yml

@@ -26,7 +26,7 @@
         bin_dir: "/usr/local/bin"
       when: not ansible_os_family in ["Flatcar", "Flatcar Container Linux by Kinvolk"]
 
-    - import_role:  # noqa unnamed-task
+    - import_role:  # noqa name[missing]
         name: cluster-dump
 
     - name: Wait for netchecker server
@@ -60,7 +60,7 @@
         - netchecker-agent-hostnet
       when: not nca_pod is success
 
-    - debug:  # noqa unnamed-task
+    - debug:  # noqa name[missing]
         var: nca_pod.stdout_lines
       when: inventory_hostname == groups['kube_control_plane'][0]
 
@@ -96,7 +96,7 @@
       when:
         - agents.content != '{}'
 
-    - debug:  # noqa unnamed-task
+    - debug:  # noqa name[missing]
         var: ncs_pod
       run_once: true
 
@@ -130,7 +130,7 @@
         - agents.content is defined
         - agents.content[0] == '{'
 
-    - debug:  # noqa unnamed-task
+    - debug:  # noqa name[missing]
         var: agents_check_result
       delegate_to: "{{ groups['kube_control_plane'][0] }}"
       run_once: true
@@ -147,7 +147,7 @@
         - connectivity_check.content is defined
         - connectivity_check.content[0] == '{'
 
-    - debug:  # noqa unnamed-task
+    - debug:  # noqa name[missing]
         var: connectivity_check_result
       delegate_to: "{{ groups['kube_control_plane'][0] }}"
       run_once: true