rebase on k8s 1.10.1 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
I thought we have travis CI for at least unit test since I saw trivis config file. |
mengqiy
force-pushed
the
rebase_k8s_1_10
branch
2 times, most recently
from
0a0f9e5 to
ee787f6
Compare
|
@mengqiy @pwittrock Yes, I am still working on the travis setup. hope to get it working today. @mengqiy Can you run all the tests locally for this PR ? |
|
@mengqiy We need to update thirdparty tools for k8s1.10 as well and make them available as docker image. |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
@pwittrock Thanks. We also tested it with 1.9 thirdparty tools and the basic tests passed. We are going to merge this in the morning after a few more tests and then do a release. |
|
SGTM |
mengqiy
force-pushed
the
rebase_k8s_1_10
branch
from
6f9a236 to
0f3c5cd
Compare
droot
approved these changes
Apr 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.