-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Use explicit docker.io prefix for Docker Hub images #4513
Conversation
fixes build failure with non-docker builders like buildah Signed-off-by: Tom Plant <[email protected]>
Welcome @pl4nty! |
Hi @pl4nty. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, pl4nty The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override pull-kubebuilder-e2e-k8s-1-32-0 |
@camilamacedo86: Overrode contexts on behalf of camilamacedo86: pull-kubebuilder-e2e-k8s-1-32-0 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes build failure with non-docker builders like buildah in docs and scaffolding. Initially reported in my operator that closely aligns to scaffolding, so I figured I'd upstream the fix.
Docker's builder uses
docker.io
by default if no prefix is provided, but buildah doesn't, and I don't think it's part of the spec.