-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 fix: remove unused nolint comments #4468
🌱 fix: remove unused nolint comments #4468
Conversation
Signed-off-by: Mateus Oliveira <[email protected]>
Hi @mateusoliveira43. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -22,6 +22,8 @@ linters-settings: | |||
disable: | |||
- fieldalignment | |||
- shadow | |||
nolintlint: | |||
allow-unused: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this one?
What it does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it checks for unnecessary //nolint
comments
for example a line was to long, so we added //nolint:lll
to it
in another moment, the line was changed, and it is now not too long, so //nolint
comment is not necessary anymore
with this config, that line would be highlighted to remove the now not needed //nolint
comment
/ok-to-test |
@mateusoliveira43: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mateusoliveira43, Scutua The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There are unnecessary
//nolint
comments in project codeThis PR removes these unnecessary comments and enforces that no new
//nolint
unnecessary comments are added to the code