🐛 (kustomize/v2,go/v4): Move cert-manager uncomment block to top of kustomization.yaml for better visibility in new projects #4283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
camilamacedo86
commented
Nov 2, 2024
camilamacedo86
commented
- Relocated the cert-manager setup block (kind: Service, version: v1, name: webhook-service) to improve user experience since this one must be uncommented always and was hard to identify as it was organized previously.
- Change only affects new projects.
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
…tomization.yaml for better visibility in new projects - Relocated the cert-manager setup block (kind: Service, version: v1, name: webhook-service) to improve user experience. - Change only affects new projects.
camilamacedo86
force-pushed
the
make-easy-certmanager-uncomment
branch
from
2b46437 to
5456002
Compare
|
We are not really change anything here
I am moving forward due be too small and it is blocking other PRs which we really need help on reviews: #4282 (this PR make easier we check the changes of) |
camilamacedo86
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.