Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fixed Duplicate Webhook Patch Entries when Creating Multiple Ver… #4220

Merged
merged 1 commit into from
Oct 17, 2024
Merged

🐛 fixed Duplicate Webhook Patch Entries when Creating Multiple Ver… #4220

merged 1 commit into from
Oct 17, 2024

Conversation

Bharadwajshivam28
Copy link
Member

fixes #4143

Hey @camilamacedo86 I gave it a try and used the approach that-

  1. created marker and stored the marker in a variable.
  2. checked if the marker already exists ignoring the value part only checking key
  3. If the marker doesn't exist in fragments add the webhookPatch to the fragments. If it already exists, we skip adding it.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2024
@Bharadwajshivam28 Bharadwajshivam28 changed the title fix: fixed Duplicate Webhook Patch Entries when Creating Multiple Ver… 🐛 fixed Duplicate Webhook Patch Entries when Creating Multiple Ver… Oct 16, 2024
camilamacedo86
camilamacedo86 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you a lot for your contribution 🥇

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bharadwajshivam28, camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit bde03b7 into kubernetes-sigs:master Oct 17, 2024
17 of 18 checks passed
@Bharadwajshivam28 Bharadwajshivam28 deleted the fix/Duplicate_Webhook branch October 17, 2024 20:19
@camilamacedo86 camilamacedo86 mentioned this pull request Oct 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
3 participants
@Bharadwajshivam28 @k8s-ci-robot @camilamacedo86