Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 (doc): remove section in the platform documentation which says that kube-rbac-proxy is an image provided by default #4187

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Sep 22, 2024

The usage of kube-rbac-proxy was discontinue and the image is no longer build or promoted by the project. Therefore, this section needs to be removed to avoid misleadings. More info: #3907

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 22, 2024
…ube-rbac-proxy is an image provided by default

The usage of kube-rbac-proxy was discontinue and the image is no longer
build or promoted by the project. Therefore, this section needs to be removed
to avoid misleadings
@camilamacedo86 camilamacedo86 force-pushed the remove-kube-rbac-proxy-from-platform branch from 91f926a to 21e9dba Compare September 22, 2024 19:58
Copy link
Member Author

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have many open PRs where we need help to review
this one is quite solid we are just removing in outdated info
So, I am moving forward for not make nobody waste time here.

@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit fb58aef into kubernetes-sigs:master Sep 22, 2024
10 checks passed
@camilamacedo86 camilamacedo86 deleted the remove-kube-rbac-proxy-from-platform branch September 23, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants