🐛 (go/v4): fix linter issues to allow pass in the stricter linter checks such as; godot, gofumpt, nlreturn

[pgaxatte]

As described in #4132 I'd like to propose to fix some minor format issues that prevents us from using a stricter linter out of the box.

[linux-foundation-easycla]

• ❌ The email address for the commit (c4242a0) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

[k8s-ci-robot]

Welcome @pgaxatte!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @pgaxatte. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

Thank you for the contribution 🥇

Could you please just run make install and then make generate so that we have all samples under testdata and doc updated with your changes?

Otherwise, we cannot get this one merged.
Thank you

[pgaxatte]

Thanks for the guidance!

I ran make generate and the generate-docs target failed with an error so I had to make adjustments in hack/docs/internal/cronjob-tutorial/generate_cronjob.go also.

[camilamacedo86]

Hi @

I ran make generate and the generate-docs target failed with an error so I had to make adjustments in hack/docs/internal/cronjob-tutorial/generate_cronjob.go also.

It was expected. The hack docs re-scaffold the project and add on top the code examples and pieces of the doc so that we keep all updated with the latest changes. Thank you.

Just more one detail. See that for we get the PR merged you need to sign the cnfc-cla : #4133 (comment). Passing on this test we can get this one merged !!!
Could you please do that?

Thank you a lot for your contribution !

[camilamacedo86]

/ok-to-test
/approved

[varshaprasad96]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pgaxatte, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [varshaprasad96]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

Hi @pgaxatte

Did you saw my comment #4133 (comment)

You need sign the CNFC-CLA so that we can ge this one merged, see: #4133 (comment)

Thank you a lot!

[pgaxatte]

Hi @camilamacedo86, I saw it and tried to fix it yesterday without success, I'm retrying quickly

[pgaxatte]

/check-cla

[pgaxatte]

CLA related issue looks good to me now, thanks for your patience

[camilamacedo86]

Thank you a lot @pgaxatte for your contribution 🥇

Now, you have all place for the future ones !!!
Well done 🚀