✨ (go/v4) Add GitHub Actions #4110
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/XL
camilamacedo86
force-pushed
the
add-github-ci
branch
18 times, most recently
from
ba717f3 to
2b58377
Compare
camilamacedo86
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
add-github-ci
branch
from
b263120 to
aba4985
Compare
camilamacedo86
force-pushed
the
add-github-ci
branch
6 times, most recently
from
b8fb2aa to
77decdb
Compare
camilamacedo86
changed the title
k8s-ci-robot
added
do-not-merge/hold
camilamacedo86
force-pushed
the
add-github-ci
branch
from
77decdb to
b9dbd36
Compare
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
| @@ -161,6 +162,9 @@ func (s *initScaffolder) Scaffold() error { | |||
| &templates.Golangci{}, | |||
| &e2e.Test{}, | |||
| &e2e.SuiteTest{}, | |||
| &github.E2eTestCi{}, | |||
| &github.TestCi{}, | |||
There was a problem hiding this comment.
@camilamacedo86 Everything looks good to me. Just one question: Is it necessary to maintain separate files for each of GH Action template?
There was a problem hiding this comment.
We want to set up 3 separate jobs as follows:
Each job will have its own file so that if a failure occurs, it's easy to identify which target/job/test failed. Running the jobs in parallel will also make the process faster and easier to manage.
This separation also makes it clear which file corresponds to each task: test.yml for tests, lint.yml for linting, and so on. This approach simplifies any future changes and helps maintain clarity—if everything were in the same file, it would be more challenging to pinpoint issues and make updates.
There was a problem hiding this comment.
@camilamacedo86 makes sense to maintain the separation of concern. Everything else seems good for now.
| - name: Run linter | ||
| uses: golangci/golangci-lint-action@v6 | ||
| with: | ||
| version: v1.59 |
There was a problem hiding this comment.
Nit: what about using the latest release v1.61.0?
There was a problem hiding this comment.
I added the same version that we are using.
so we can upgrade all by once
|
|
||
| - name: Running Test e2e | ||
| run: | | ||
| go mod tidy |
There was a problem hiding this comment.
Nit: looks like an additional indent here?
There was a problem hiding this comment.
Lets fix this one before get merged
Good catcher !!
/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, Kavinjsir, TAM360 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add GitHub actions to the default scaffold. Motivation: - help developers use the tests in the CI - make clear the purpose of the e2e tests scaffolds - encourage good practices and standard approachs
camilamacedo86
force-pushed
the
add-github-ci
branch
from
b9dbd36 to
5a69aac
Compare
|
/hold cancel Now it is good to fly 🎉 |
camilamacedo86
added
the
lgtm
Within the changes of this PR new projects will become to be scaffold with GitHub actions which will allow users be aware of how to test their changes on the ci.
Either will make clear the purpose of the test-e2e and encorage common/best practices to ensure the quality of the properties
Closes: #4088