Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 fix error faced during release process by ensuring dist directory is cleaned before running GoReleaser #4040

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Jul 23, 2024

Follow up of: Update release.yml - Update goreleaser from 1.11.2 to v2.1.0 by @camilamacedo86 in #4031

Note that the --rm-dist flag in GoReleaser was used to remove the dist directory before starting the release process. This ensured that any old build artifacts from previous runs were deleted, providing a clean environment for the new release.

Address the issue faced in the release of 4.1.1: https://github.com/kubernetes-sigs/kubebuilder/actions/runs/10054025442/job/27787845571

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 23, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 23, 2024
@camilamacedo86 camilamacedo86 added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2024
@camilamacedo86
Copy link
Member Author

Fix action after the upgrade of gorelease
Minor no need to ask for nobody waste time on reviews
moving forward

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 23, 2024
@camilamacedo86 camilamacedo86 merged commit e4beb77 into kubernetes-sigs:master Jul 23, 2024
15 of 20 checks passed
@camilamacedo86 camilamacedo86 deleted the fix-github-action-after-gorelease-upgrade branch July 23, 2024 06:55
camilamacedo86 added a commit to camilamacedo86/kubebuilder that referenced this pull request Jul 24, 2024
…s cleaned before running GoReleaser (kubernetes-sigs#4040)

fix error faced during release process by ensuring dist directory is cleaned before running GoReleaser
camilamacedo86 added a commit to camilamacedo86/kubebuilder that referenced this pull request Jul 24, 2024
…s cleaned before running GoReleaser (kubernetes-sigs#4040)

fix error faced during release process by ensuring dist directory is cleaned before running GoReleaser
camilamacedo86 added a commit to camilamacedo86/kubebuilder that referenced this pull request Jul 24, 2024
…s cleaned before running GoReleaser (kubernetes-sigs#4040)

fix error faced during release process by ensuring dist directory is cleaned before running GoReleaser
camilamacedo86 added a commit to camilamacedo86/kubebuilder that referenced this pull request Jul 24, 2024
…s cleaned before running GoReleaser (kubernetes-sigs#4040)

fix error faced during release process by ensuring dist directory is cleaned before running GoReleaser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants