Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ (declarative/v1) : Update the sigs.k8s.io/kubebuilder-declarative-pattern dep used for projects scaffolded with go/v3 plugin from fea7e5cc701290589ec20ef4d9c0629d08b5307d to d0f104b6a96e152043e9c2d76229373a981ac96a #2682

Merged
merged 1 commit into from
May 17, 2022
Merged

✨ (declarative/v1) : Update the sigs.k8s.io/kubebuilder-declarative-pattern dep used for projects scaffolded with go/v3 plugin from fea7e5cc701290589ec20ef4d9c0629d08b5307d to d0f104b6a96e152043e9c2d76229373a981ac96a #2682

merged 1 commit into from
May 17, 2022

Conversation

NikhilSharmaWe
Copy link
Member

@NikhilSharmaWe NikhilSharmaWe commented May 12, 2022 •
edited
Loading

Description

Update the sigs.k8s.io/kubebuilder-declarative-pattern dep used for projects scaffolded with go/v3 plugin from fea7e5cc701290589ec20ef4d9c0629d08b5307d to d0f104b6a96e152043e9c2d76229373a981ac96a

See the comparison between the two versions: kubernetes-sigs/kubebuilder-declarative-pattern@fea7e5c...d0f104b

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 12, 2022
@k8s-ci-robot k8s-ci-robot requested review from Adirio and estroz May 12, 2022 12:11
@NikhilSharmaWe NikhilSharmaWe force-pushed the kbDeclarativePatternForV3 branch from 3f6e19c to c3191e9 Compare May 12, 2022 12:21
camilamacedo86
camilamacedo86 reviewed May 14, 2022
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NikhilSharmaWe thank you for the contribution 🥇

Following its review:

  1. We need have the title and comment with the info for the changelogs

See that ⚠️ means breaking changes, and I do not see any change on the files after we pinned them.
Also, we can check the changes by: kubernetes-sigs/kubebuilder-declarative-pattern@fea7e5c...d0f104b

So, could you:

a) Update the title and commit:

✨ (declarative/v1) : Update the sigs.k8s.io/kubebuilder-declarative-pattern dep used for projects scaffolded with go/v3 plugin from fea7e5cc701290589ec20ef4d9c0629d08b5307d to d0f104b6a96e152043e9c2d76229373a981ac96a

b) Could you update the description here with:

Update the sigs.k8s.io/kubebuilder-declarative-pattern dep used for projects scaffolded with go/v3 plugin from fea7e5cc701290589ec20ef4d9c0629d08b5307d to d0f104b6a96e152043e9c2d76229373a981ac96a

And add the link to compare what changed between one version to another?

@NikhilSharmaWe NikhilSharmaWe changed the title ⚠ Updated v1.kbDeclarativePatternForV3 with the latest commit in kubernetes-sigs/kubebuilder-declarative-pattern ✨ (declarative/v1) : Update the sigs.k8s.io/kubebuilder-declarative-pattern dep used for projects scaffolded with go/v3 plugin from fea7e5cc701290589ec20ef4d9c0629d08b5307d to d0f104b6a96e152043e9c2d76229373a981ac96a May 14, 2022
@NikhilSharmaWe NikhilSharmaWe force-pushed the kbDeclarativePatternForV3 branch from c3191e9 to 384511c Compare May 14, 2022 07:57
@NikhilSharmaWe
✨ (declarative/v1) : Update the sigs.k8s.io/kubebuilder-declarative-p…
38823f7 
…attern dep used for projects scaffolded with go/v3 plugin from fea7e5cc701290589ec20ef4d9c0629d08b5307d to d0f104b6a96e152043e9c2d76229373a981ac96a
@NikhilSharmaWe NikhilSharmaWe force-pushed the kbDeclarativePatternForV3 branch from 384511c to 38823f7 Compare May 14, 2022 08:10
camilamacedo86
camilamacedo86 approved these changes May 14, 2022
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That shows nice 🥇

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2022
everettraven
everettraven approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, everettraven, NikhilSharmaWe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

NikhilSharmaWe
NikhilSharmaWe commented May 17, 2022
View reviewed changes
pkg/plugins/golang/declarative/v1/api.go
@@ -32,7 +32,7 @@ import (
const (
// kbDeclarativePattern is the sigs.k8s.io/kubebuilder-declarative-pattern version
kbDeclarativePatternForV2 = "v0.0.0-20200522144838-848d48e5b073"
kbDeclarativePatternForV3 = "fea7e5cc701290589ec20ef4d9c0629d08b5307d"
kbDeclarativePatternForV3 = "d0f104b6a96e152043e9c2d76229373a981ac96a"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camilamacedo86 Can we merge this one.

And could you please take a look at kubernetes-sigs/kubebuilder-declarative-pattern#217 which bumps versions of k8s dependencies and controller-runtime and k8s dependencies in kubebuilder-declarative-pattern. It is showing breaking API changes in kubectl / cli-utils similar to what we get in #2679.

@camilamacedo86
Copy link
Member

I think we can move forward with this one 👍

@camilamacedo86
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2022
@camilamacedo86
Copy link
Member

/test pull-kubebuilder-e2e-k8s-1-14-10

@k8s-ci-robot k8s-ci-robot merged commit 87c5fc8 into kubernetes-sigs:master May 17, 2022
@everettraven everettraven mentioned this pull request Jun 24, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@everettraven everettraven everettraven approved these changes

@Adirio Adirio Awaiting requested review from Adirio

@estroz estroz Awaiting requested review from estroz

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NikhilSharmaWe @k8s-ci-robot @camilamacedo86 @everettraven