-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ (go/v3): Add README.md template to scaffolding templates #2610
✨ (go/v3): Add README.md template to scaffolding templates #2610
Conversation
Welcome @everettraven! |
Hi @everettraven. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the great contribution 🥇
some nits were added in the review.
Also,
a) could we update the title to clarifies that the addition is valid only for go/v3 plugins with :
✨ (go/v3) : Add ...
b) could you please squash the commits? We need have 1 commit per PR?
dee7b87
to
8fb7288
Compare
Both of these should now be done. Thanks for the detailed review, it helped me learn a lot more about Operators vs Controllers and how Kubebuilder is working! |
a0faa6f
to
a2a6005
Compare
Signed-off-by: Bryce Palmer <[email protected]>
a2a6005
to
c94dabc
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a great job. 🥇
For me,
/approved
However, I think would be nice if we check with the others what they think as well.
WDYT about also adding this one in the channels?
@ryanbrainard @varshaprasad96 @rashmigottipati @jmrodri wdyt?
I will go ahead and add this to the Kubebuilder channel as a PTAL. Thanks @camilamacedo86 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@camilamacedo86 though this isn't a breaking change per say, it needs a new KB release?
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, everettraven, rashmigottipati, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of changes
This adds a new file to the go/v3 scaffolding templates for scaffolding a README.md file. The new file can be found at
pkg/plugins/golang/v3/scaffolds/internal/templates/readme.go
The file
pkg/plugins/golang/v3/init.go
was modified to add the scaffolding of the README.md file to the go/v3init
process.Motivation for the change
As per issue #2597 :
Additional Information
resolves #2597