-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨(go/v3) : Made changes so that setup-envtest module version matches with the controller-runtime version instead of latest #2587
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: NikhilSharmaWe The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We need to discuss the approach, see: #2480 (comment) |
…ith the controller-runtime version instead of latest
3bff7ba
to
0f56b1b
Compare
@NikhilSharmaWe: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@NikhilSharmaWe: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@NikhilSharmaWe I am closing this one because we need to discuss and convey regards the approach, see: #2480 (comment) |
Fixes #2480