Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨(go/v3) : Made changes so that setup-envtest module version matches with the controller-runtime version instead of latest #2587

Closed

Conversation

NikhilSharmaWe
Copy link
Member

Fixes #2480

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NikhilSharmaWe
To complete the pull request process, please assign camilamacedo86 after the PR has been reviewed.
You can assign the PR to them by writing /assign @camilamacedo86 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86
Copy link
Member

camilamacedo86 commented Apr 1, 2022

We need to discuss the approach, see: #2480 (comment)
Also, should we apply only in go/v3 or is it valid for go/v2 either
If we decide to move forward here and only with go/v3 this info must be in the commit-msg and title, so that we can properly generate the release notes.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2022
@NikhilSharmaWe NikhilSharmaWe changed the title ✨Made changes so that setup-envtest module version matches with the controller-runtime version instead of latest ✨(go/v3) : Made changes so that setup-envtest module version matches with the controller-runtime version instead of latest Apr 1, 2022
…ith the controller-runtime version instead of latest
@k8s-ci-robot
Copy link
Contributor

@NikhilSharmaWe: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubebuilder-test 0f56b1b link true /test pull-kubebuilder-test
pull-kubebuilder-e2e-k8s-1-22-1 0f56b1b link false /test pull-kubebuilder-e2e-k8s-1-22-1
pull-kubebuilder-e2e-k8s-1-23-3 0f56b1b link false /test pull-kubebuilder-e2e-k8s-1-23-3
pull-kubebuilder-e2e-k8s-1-18-8 0f56b1b link false /test pull-kubebuilder-e2e-k8s-1-18-8
pull-kubebuilder-e2e-k8s-1-16-15 0f56b1b link true /test pull-kubebuilder-e2e-k8s-1-16-15
pull-kubebuilder-e2e-k8s-1-17-11 0f56b1b link false /test pull-kubebuilder-e2e-k8s-1-17-11
pull-kubebuilder-e2e-k8s-1-21-2 0f56b1b link false /test pull-kubebuilder-e2e-k8s-1-21-2
pull-kubebuilder-e2e-k8s-1-20-7 0f56b1b link false /test pull-kubebuilder-e2e-k8s-1-20-7
pull-kubebuilder-e2e-k8s-1-19-4 0f56b1b link false /test pull-kubebuilder-e2e-k8s-1-19-4

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2022
@k8s-ci-robot
Copy link
Contributor

@NikhilSharmaWe: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@camilamacedo86
Copy link
Member

@NikhilSharmaWe I am closing this one because we need to discuss and convey regards the approach, see: #2480 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install setup-envtest module version which matching with the controller-runtime version instead of latest
3 participants