✨ (config-gen alpha command): upgrade sigs.k8s.io/controller-tools from v0.7.0 to v0.8.0

[AlmogBaku]

Description:

Update the controller-tools dep from 0.7.0 to .0.8.0 in the Kubebuilder CLI go mod which is only used by config-gen (alpha command).

Motivation

We could check that when we try to use the go version 1.18 the following errors are faced when the unit tests to check config-gen are executed. see :

/Users/AlmogBaku/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/builder/webhook.go:27:2: missing go.sum entry for module providing package k8s.io/client-go/rest (imported by sigs.k8s.io/controller-runtime/pkg/builder); to add:
	go get sigs.k8s.io/controller-runtime/pkg/[email protected]
/Users/AlmogBaku/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/client/patch.go:22:2: missing go.sum entry for module providing package github.com/evanphx/json-patch (imported by sigs.k8s.io/controller-runtime/pkg/client); to add:
	go get sigs.k8s.io/controller-runtime/pkg/[email protected]
/Users/AlmogBaku/go/pkg/mod/k8s.io/[email protected]/pkg/util/proto/document.go:24:2: missing go.sum entry for module providing package github.com/googleapis/gnostic/openapiv2 (imported by k8s.io/kube-openapi/pkg/util/proto); to add:
	go get k8s.io/kube-openapi/pkg/util/[email protected]
/Users/AlmogBaku/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/client/watch.go:26:2: missing go.sum entry for module providing package k8s.io/client-go/dynamic (imported by sigs.k8s.io/controller-runtime/pkg/client); to add:
	go get sigs.k8s.io/controller-runtime/pkg/[email protected]

Why?

Tests were failing due to a missing go.mod project.
This was caused by a bizarre bug in go list, which it couldn't locate the appropriate go module.

The issue caused a lot of silent errors which complained upon the issue described above. Up until go 1.18 it was probably silenced totally, but now it's just panicing.

Solution:

1. Do not ignore errors when creating the Runtime :)
2. Solve the root cause by adding a go module in the pkg/cli/alpha/config-gen/testdata
3. Upgrade outdated dependencies

Notes:

This PR is high-priority since it's blocking other PRs
Closes #2567

That was a tricky one ;-)

[k8s-ci-robot]

Hi @AlmogBaku. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AlmogBaku]

/cc @camilamacedo86

[camilamacedo86]

/ok-to-test

[camilamacedo86]

It is broken the unit-test checks
Could you please check?

[AlmogBaku]

/retest

[camilamacedo86]

/test pull-kubebuilder-e2e-k8s-1-16-15

[camilamacedo86]

@AlmogBaku , thank you for the great contribution 🥇

Just a nit: The title description shows not accurate
Why?

🌱 fix unit tests (config-gen bug)

We have no bug in the tests. They work.
The problem is faced only when we try to use go 1.18
So, we need to update the required deps used by config-gen

Then, could we keep only the text from the ✨ ?

Also, about the description? Could we update for something like follows?WDYT?

**Description**
Update the controller-tools dep from 0.7.0 to .0.8.0 in the Kubebuilder CLI go mod which is only used by config-gen (alpha command). 

**Motivation**
We could check that when we try to use the go version 1.18 the following errors are faced when the unit tests to check config-gen are executed. see :

/Users/AlmogBaku/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/builder/webhook.go:27:2: missing go.sum entry for module providing package k8s.io/client-go/rest (imported by sigs.k8s.io/controller-runtime/pkg/builder); to add:
	go get sigs.k8s.io/controller-runtime/pkg/[email protected]
/Users/AlmogBaku/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/client/patch.go:22:2: missing go.sum entry for module providing package github.com/evanphx/json-patch (imported by sigs.k8s.io/controller-runtime/pkg/client); to add:
	go get sigs.k8s.io/controller-runtime/pkg/[email protected]
/Users/AlmogBaku/go/pkg/mod/k8s.io/[email protected]/pkg/util/proto/document.go:24:2: missing go.sum entry for module providing package github.com/googleapis/gnostic/openapiv2 (imported by k8s.io/kube-openapi/pkg/util/proto); to add:
	go get k8s.io/kube-openapi/pkg/util/[email protected]
/Users/AlmogBaku/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/client/watch.go:26:2: missing go.sum entry for module providing package k8s.io/client-go/dynamic (imported by sigs.k8s.io/controller-runtime/pkg/client); to add:
	go get sigs.k8s.io/controller-runtime/pkg/[email protected]

Otherwise,
/approved

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlmogBaku, camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

The API diff fails here because of the changes in the yaml dep:

sigs.k8s.io/kustomize/kyaml/fn/framework
  Incompatible changes:
  - Field.CurrentValue: changed from string to interface{}
  - Field.SuggestedValue: removed
  - ResourceList.Result: removed
  - Result.Error: removed
  - Result.ExitCode: removed
  - Result.Items: removed
  - Result.Name: removed
  - ResultItem: removed

It is only used by config-gen:

sigs.k8s.io/kustomize/kyaml v0.10.21 // for `kubebuilder alpha config-ge

Config-gen is an alpha command.
So that is not a reason for we block this PR.

[AlmogBaku]

@camilamacedo86 done

Can you please LGTM it?

[camilamacedo86]

/lgtm