🐛 add the path to Kubebuilder assets in go/v3 projects #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
varshaprasad96
changed the title
estroz
reviewed
Jul 28, 2021
varshaprasad96
force-pushed
the
fix/kb-assets-bug
branch
from
6540f1f to
1dcd82b
Compare
estroz
reviewed
Jul 28, 2021
varshaprasad96
force-pushed
the
fix/kb-assets-bug
branch
from
1dcd82b to
96b42d5
Compare
estroz
reviewed
Jul 28, 2021
varshaprasad96
force-pushed
the
fix/kb-assets-bug
branch
from
96b42d5 to
b17b6d4
Compare
estroz
reviewed
Jul 28, 2021
varshaprasad96
force-pushed
the
fix/kb-assets-bug
branch
2 times, most recently
from
e3205ca to
ed1e9f1
Compare
estroz
reviewed
Jul 28, 2021
Currently, while setting up envtest and running controller tests in go/v3 projects, we look for the binary in the default location. With the changes made in `setup-envtest`, the kb assets are downloaded at tmp/k8s/<os_specific_location>. This fix sets the KUBEBUILDER_ASSETS var to point to the location where they are downloaded so that `make test` does not fail. Signed-off-by: varshaprasad96 <[email protected]>
varshaprasad96
force-pushed
the
fix/kb-assets-bug
branch
from
ed1e9f1 to
bbaccfb
Compare
k8s-ci-robot
added
size/S
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: estroz, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, while setting up envtest and running controller
tests in go/v3 projects, we look for the binary in the default
location. With the changes made in
setup-envtest, the kb assetsare downloaded at tmp/k8s/<os_specific_location>. This fix sets
the KUBEBUILDER_ASSETS var to point to the location where they
are downloaded so that
make testdoes not fail.More details on the issue: operator-framework/operator-sdk#5090