⚠ Add --plural flag (go/v3) #1967
Conversation
k8s-ci-robot
added
cncf-cla: yes
Adirio
force-pushed
the
plurals
branch
2 times, most recently
from
46366a5 to
445ed3d
Compare
Adds the flags and the required marker to the types file. Signed-off-by: Adrian Orive Oneca <[email protected]>
| $kb create webhook --group crew --version v1 --kind Admiral --plural=admirales --defaulting | ||
| else | ||
| $kb create api --group crew --version v1 --kind Admiral --controller=true --resource=true --namespaced=false --make=false | ||
| $kb create webhook --group crew --version v1 --kind Admiral --defaulting | ||
| fi |
There was a problem hiding this comment.
checked that the changes here does not change the current scenarios and just add a new one to check a plural with an irregular form for an api and webhook
|
I asked @prafull01 to check if this PR solved the Issue he raised (#1805) and he kindly agreed to check it (Thank you!). |
There was a problem hiding this comment.
It has a mojo as breaking changes just because for webhooks kb had a flag fs.StringVar(&p.options.Plural, "resource", "", "resource irregular plural form") which was changed to plural to be aligned with its bug fix for Apis.
So, since it shows a very simple bug fix and requested by users from the community via slack who face issues to scaffold an api with an irregular plural form .. well done 🥇 then, I am happy in
/lgtm
/approve
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Adds the flags and the required marker to the types file.
Fixes: #1805
Closes: #1802