Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Tolerate "dot" directories when checking if dir is empty #1944

Merged
merged 1 commit into from
Jan 29, 2021
Merged

✨ Tolerate "dot" directories when checking if dir is empty #1944

merged 1 commit into from
Jan 29, 2021

Conversation

justinsb
Copy link
Contributor

Many users will be running version control; we should ignore .git
directories also therefore.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 13, 2021
@k8s-ci-robot k8s-ci-robot requested review from droot and mengqiy January 13, 2021 12:56
@justinsb
Copy link
Contributor Author

I'll rebase this to fix the lint line-length problem after #1943

@Adirio
Copy link
Contributor

Adirio commented Jan 13, 2021

Does #1943 justify doing this in 2 different PRs? Maybe you can use two commits if you want to split the clarity change and the functionality change.

@Adirio Adirio mentioned this pull request Jan 13, 2021
Merged
@Adirio
Copy link
Contributor

Adirio commented Jan 15, 2021

I'll rebase this to fix the lint line-length problem after #1943

@justinsb as you expected, this PR needs a rebase and don't forget about the lll linting error.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2021
@Adirio Adirio mentioned this pull request Jan 26, 2021
Closed
@daenney daenney mentioned this pull request Jan 26, 2021
Closed
Adirio
Adirio suggested changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@Adirio Adirio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the three suggested changes (one of them is in the above comment) are applied, this LGTM.

pkg/plugins/golang/v3/init.go Outdated Show resolved Hide resolved
pkg/plugins/golang/v3/init.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 29, 2021
@justinsb @Adirio
Tolerate "dot" directories when checking if dir is empty
4fd2cd7 
Many users will be running version control; we should ignore .git
directories also therefore.  We ignore all directories starting with
"." (just as we ignore all files starting with ".").

Also add go.sum to ignore list, as go.mod is already ignored.

Co-authored-by: Adrián <[email protected]>
@justinsb
Copy link
Contributor Author

Thanks for all the suggestions - I incorporated them all (I believe!)

Adirio
Adirio approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@Adirio Adirio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2021
@Adirio
Copy link
Contributor

Adirio commented Jan 29, 2021

Just a small NIT, can you edit the title? PR titles are used for changelogs and it is no longer only .git

@justinsb justinsb changed the title ✨ Tolerate .git directory when checking if dir is empty ✨ Tolerate "dot" directories when checking if dir is empty Jan 29, 2021
@justinsb
Copy link
Contributor Author

Thanks @Adirio - good point - changed the PR title to match the commit title (which I had remembered to update!).

camilamacedo86
camilamacedo86 approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, camilamacedo86, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit e222f25 into kubernetes-sigs:master Jan 29, 2021
@camilamacedo86 camilamacedo86 mentioned this pull request Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estroz estroz estroz left review comments

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@Adirio Adirio Adirio approved these changes

@droot droot Awaiting requested review from droot

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@Adirio Adirio

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@justinsb @Adirio @k8s-ci-robot @camilamacedo86 @estroz