Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Update kubebuilder cli and plugin v3+ to use go version 1.15 #1716

Merged
merged 1 commit into from
Oct 14, 2020
Merged

⚠️ Update kubebuilder cli and plugin v3+ to use go version 1.15 #1716

merged 1 commit into from
Oct 14, 2020

Conversation

rashmigottipati
Copy link
Contributor

@rashmigottipati rashmigottipati commented Oct 9, 2020 •
edited by camilamacedo86
Loading

Description

  • Update go version from 1.13 to 1.15

Note
Here's the link to update the infra to run the CI jobs as well: kubernetes/test-infra#19527

@k8s-ci-robot
Copy link
Contributor

Welcome @rashmigottipati!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @rashmigottipati. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 9, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 9, 2020
@rashmigottipati rashmigottipati changed the title Update kubebuilder to use go version 1.15 ⚠ Update kubebuilder to use go version 1.15 Oct 9, 2020
@camilamacedo86
Copy link
Member

camilamacedo86 commented Oct 9, 2020 •
edited
Loading

Hi @rashmigottipati,

Really thank you for your contribution. 🥇 For we are able to move forward with, you need to follow the instructions in #1716 (comment)
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 9, 2020
@camilamacedo86
Copy link
Member

/test pull-kubebuilder-e2e-k8s-1-16-2

@camilamacedo86
Copy link
Member

camilamacedo86 commented Oct 9, 2020 •
edited
Loading

Hi @DirectXMan12,

Controller-runtime has updated o use 1.15 already. Have you any objection to this change? Just to confirm.
For me it is OK. We just need also to upgrade the https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/kubebuilder/kubebuilder-presubmits.yaml#L13. Could you please push a PR for that and link in the first comment @rashmigottipati?

camilamacedo86
camilamacedo86 reviewed Oct 9, 2020
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2020
@camilamacedo86
Copy link
Member

/test pull-kubebuilder-e2e-k8s-1-16-2

@camilamacedo86 camilamacedo86 mentioned this pull request Oct 11, 2020
Closed
@rashmigottipati
Copy link
Contributor Author

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 12, 2020
@rashmigottipati
Copy link
Contributor Author

rashmigottipati commented Oct 12, 2020 •
edited
Loading

@camilamacedo86 thanks for your input Camila. I've created a PR in kubernetes/test-infra updating the go version in https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/kubebuilder/kubebuilder-presubmits.yaml#L13 to 1.15.
Here's the link: kubernetes/test-infra#19527

estroz
estroz suggested changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping the v2 plugin to go 1.15 is a breaking change because the binary will fail for previously scaffolded projects (in checkGoVersion()). I recommend only bumping in v3.

pkg/plugin/internal/util/go_version.go Outdated Show resolved Hide resolved
pkg/plugin/v2/scaffolds/internal/templates/dockerfile.go Outdated Show resolved Hide resolved
@alexeldeib alexeldeib mentioned this pull request Oct 13, 2020
Merged
@camilamacedo86
Copy link
Member

/test pull-kubebuilder-e2e-k8s-1-14-1

/test pull-kubebuilder-e2e-k8s-1-16-2

@estroz
Copy link
Contributor

estroz commented Oct 14, 2020

@rashmigottipati can you add a comment above checkGoVersion() as to why it wasn't updated? (because the kubebuilder binary only cares that the go binary supports modules, which were on by default in go 1.13)

@rashmigottipati
Copy link
Contributor Author

thanks @estroz, just added a comment as per our discussion.

estroz
estroz approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2020
@estroz
Copy link
Contributor

estroz commented Oct 14, 2020

/retest

@rashmigottipati rashmigottipati changed the title ⚠ Update kubebuilder to use go version 1.15 ⚠️ Update kubebuilder cli and plugin v3+ to use go version 1.15 Oct 14, 2020
@rashmigottipati
Copy link
Contributor Author

/test pull-kubebuilder-e2e-k8s-1-14-1

/test pull-kubebuilder-e2e-k8s-1-16-2

@estroz
Copy link
Contributor

estroz commented Oct 14, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit c993a2a into kubernetes-sigs:master Oct 14, 2020
@camilamacedo86 camilamacedo86 mentioned this pull request Feb 18, 2021
Closed
@rashmigottipati rashmigottipati deleted the update-go-version branch June 17, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 left review comments

@estroz estroz estroz approved these changes

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@droot droot Awaiting requested review from droot

Assignees

@estroz estroz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rashmigottipati @k8s-ci-robot @camilamacedo86 @estroz