Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add undeploy IMG option (V3 only) #1571

Merged
merged 1 commit into from
Jun 29, 2020
Merged

feat: add undeploy IMG option (V3 only) #1571

merged 1 commit into from
Jun 29, 2020
+24 −0

Conversation

camilamacedo86
Copy link
Member

Add option to undeploy controller.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 20, 2020
@camilamacedo86 camilamacedo86 changed the title feat: add undeploy IMG option feat: add undeploy IMG option (V3 only) Jun 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from Adirio and pwittrock June 20, 2020 11:33
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 20, 2020
@camilamacedo86
Copy link
Member Author

c/c @joelanford

@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-14-1
/test pull-kubebuilder-e2e-k8s-1-16-2

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2020
@camilamacedo86
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2020
@camilamacedo86 camilamacedo86 requested a review from pwittrock June 28, 2020 13:06
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-16-2

@pwittrock
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0cdba0b into kubernetes-sigs:master Jun 29, 2020
@camilamacedo86 camilamacedo86 mentioned this pull request Jul 25, 2020
Closed
@gabbifish gabbifish mentioned this pull request Aug 28, 2020
Closed
6 tasks
@camilamacedo86 camilamacedo86 mentioned this pull request Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabbifish gabbifish gabbifish left review comments

@Adirio Adirio Awaiting requested review from Adirio

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@pwittrock pwittrock

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@camilamacedo86 @k8s-ci-robot @pwittrock @gabbifish