-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: fix for controller-runtime 0.6.0 GetFieldIndexer().IndexField ctx param #1533
Conversation
Welcome @calmkart! |
Hi @calmkart. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @camilamacedo86 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is true. Checked. 👍
/ok-to-test
@calmkart you need rebase with the master to get the CI fix. Could you please do that? |
/lgtm cancel |
/hold cancel |
done |
@@ -544,7 +544,7 @@ func (r *CronJobReconciler) SetupWithManager(mgr ctrl.Manager) error { | |||
r.Clock = realClock{} | |||
} | |||
|
|||
if err := mgr.GetFieldIndexer().IndexField(&kbatch.Job{}, jobOwnerKey, func(rawObj runtime.Object) []string { | |||
if err := mgr.GetFieldIndexer().IndexField(context.Background(), &kbatch.Job{}, jobOwnerKey, func(rawObj runtime.Object) []string { | |||
// grab the job object, extract the owner... | |||
job := rawObj.(*kbatch.Job) | |||
owner := metav1.GetControllerOf(job) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to the same for : docs/book/src/multiversion-tutorial/testdata/project/controllers/cronjob_controller.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
/hold cancel |
/approve Tks for the contribution 👍 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: calmkart, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
in [email protected] the FieldIndexer interface is
fix to add a context to IndexField method
just a small fix