-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: example of age print column #1516
Conversation
Hi @caarlos0. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @droot |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shows ok for me so
/approved
Let's waiting for a second reviewer ok.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: caarlos0, mengqiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added an "Age" print column as an example as well.
Its a pretty common use case, and it was not obvious to me how to make it work. In my head, I would have to do something like
now - .metadata.creationTimestamp
somehow.... found that I just need to set thetype
todate
by digging the prometheus-operator codebase.Hope this makes it easier for the next people :)