-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the go check for the minimal required version #1460
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
IIRC I already tried this and there were more changes needed. Some involved modifying some of the CI tools (not sure if it was Travis, Prow, KinD or the api server images). Also, you would need to require 13+ in kubebuilder/cmd/internal/go_version.go Lines 71 to 73 in 29d1dc1
|
5e24f13
to
91eb0e1
Compare
Did you find any place that is using a go version < 1.13 ? See that Travis is using 1.13 and it is the info the Kubebuilder docs as well. Also, since all CI tests passed with the check I would assume that has not a place using a lower version too. However, please let me know if you see any reason we do not move forward here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remembered one of the tests failing but it doesn't seem to happen so:
/lgtm
I didn't realize that a @DirectXMan12 @mengqiy @droot if you consider this shouldn't be merged we can clease the mess, sorry. |
LGTM |
Description
Upgrade the go check to ensure that the version used is according to the minimal requirements