Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugins/addon: perform replacements for type and controller #1059

Merged
merged 2 commits into from
Oct 30, 2019
Merged

plugins/addon: perform replacements for type and controller #1059

merged 2 commits into from
Oct 30, 2019

Conversation

johnsonj
Copy link
Contributor

@johnsonj johnsonj commented Oct 1, 2019 •
edited
Loading

This change adds the plumbing for plugins to act on the controller and fixes the addon pattern to output a buildable controller.

changes:

  • controller runs in a second phase and needs the Plugins configured on
    the Scaffold
  • fix path to the api//_type.go file for file
    replacement
  • make the addon plugin work with the 2 phase run (api then controller)
    by not failing if the manifest/channel file has already been generated
  • fixup import paths

@johnsonj
plugins/addon: perform replacements for type and controller
c7c98f8 
- controller runs in a second phase and needs the Plugins configured on
  the Scaffold
- fix path to the api/<version>/<resource>_type.go file for file
  replacement
- make the addon plugin work with the 2 phase run (api then controller)
  by not failing if the manifest/channel file has already been generated
@k8s-ci-robot
Copy link
Contributor

Welcome @johnsonj!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 1, 2019
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 1, 2019
@johnsonj
Copy link
Contributor Author

johnsonj commented Oct 1, 2019

/cc @justinsb @DirectXMan12

@k8s-ci-robot k8s-ci-robot requested a review from justinsb October 1, 2019 05:11
@johnsonj
addoms/controller: fixup import paths
bb4132d 
a few missing imports required to make output build
This was referenced Oct 14, 2019
Closed
Closed
@justinsb
Copy link
Contributor

Thanks @johnsonj - not sure how I missed these, but you're quite right!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2019
@droot droot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: johnsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@droot
Copy link
Contributor

droot commented Oct 30, 2019

Noticed that it has one of the checks pending The Travis CI build is in progress, but travis is reporting the build to be successful. Couldn't find a way to retrigger the travis build. @mengqiy any idea how to unblock this merge ?

@mengqiy mengqiy closed this Oct 30, 2019
@mengqiy mengqiy reopened this Oct 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit 90850ad into kubernetes-sigs:master Oct 30, 2019
johnsonj added a commit to johnsonj/addon-operators that referenced this pull request Nov 18, 2019
@johnsonj
kubeproxy: regenerate boilerplate w/ plugin fix
2385c56 
regenerate controller/api code with patch[1]

[1] kubernetes-sigs/kubebuilder#1059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@pwittrock pwittrock Awaiting requested review from pwittrock

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@johnsonj @k8s-ci-robot @justinsb @droot @mengqiy