Enhance webhook_test template #4148
Labels
good first issue
Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
help wanted
Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
kind/bug
Categorizes issue or PR as related to a bug.
release-blocker
What broke? What's expected?
We need to address this in the scaffold. See: webhook_test_template.go.
More information can be found in the comments raised in this PR.
Reproducing this issue
Odd Indentation:
Improvements to gomega usage:
Replace : Expect(err).NotTo(HaveOccurred())
With: Expect(obj.Default(ctx)).To(Succeed())
Replace: warnings, err := obj.ValidateCreate(ctx)
With: Expect(obj.ValidateCreate(ctx)).Error().To(HaveOccurred())
See that we will need to either change the contents that we find/replace to generate the docs samples under the hack/docs.
KubeBuilder (CLI) Version
master
PROJECT version
No response
Plugin versions
No response
Other versions
No response
Extra Labels
No response
The text was updated successfully, but these errors were encountered: