Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can we add more detailed example in metrics doc? #1522

Closed
caneGuy opened this issue May 19, 2020 · 6 comments
Closed

can we add more detailed example in metrics doc? #1522

caneGuy opened this issue May 19, 2020 · 6 comments
Labels
kind/support Categorizes issue or PR as a support question.

Comments

@caneGuy
Copy link

caneGuy commented May 19, 2020

After following https://book.kubebuilder.io/reference/metrics.html?highlight=metr#metrics i can not see the registered metrics on prometheus UI. Some suggestion:

  1. add a ServiceMonitor yaml example?
  2. add a complete example for additional metrics?
  3. the picture in the doc only show original metrics of prometheus.IIUC, all the metrics can also be seen if we do not deploy a servicemonitor
@caneGuy caneGuy added the kind/support Categorizes issue or PR as a support question. label May 19, 2020
@caneGuy
Copy link
Author

caneGuy commented May 19, 2020

@camilamacedo86 thanks!

@caneGuy caneGuy changed the title can we have more detail example in metrics doc? can we have more detailed example in metrics doc? May 19, 2020
@caneGuy caneGuy changed the title can we have more detailed example in metrics doc? can we add more detailed example in metrics doc? May 19, 2020
@camilamacedo86
Copy link
Member

camilamacedo86 commented May 19, 2020

HI @caneGuy,

It is not clear for me if you are looking for improvements in the docs based on your experience following it or help to achieve your goal and use the Prometheus Operator to export the metrics. Could you please let us know?

Also, if you are looking for help with, could you please to provide the following info? However, if you are just looking for improvements in the docs, please feel free to contribute with and raise a PR against the master with your suggestions and ideas.

What did you do?
A clear and concise description of the steps you took (or insert a code snippet).

What did you expect to see?
A clear and concise description of what you expected to happen (or insert a code snippet).

What did you see instead? Under which circumstances?
A clear and concise description of what you expected to happen (or insert a code snippet).

Also, did you installed the Prometheus Operator? If yes, did you follow you the install doc? Are you using minikube? If yes, did you follow-ups its pre-requisites describe in the Prometheus Operator see?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 17, 2020
@camilamacedo86
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 17, 2020
@camilamacedo86
Copy link
Member

/close
since it achieves the time without having no reply provide further info for we know how we can address it.

@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: Closing this issue.

In response to this:

/close
since it achieves the time without having no reply provide further info for we know how we can address it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/support Categorizes issue or PR as a support question.
Projects
None yet
Development

No branches or pull requests

4 participants