-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metrics-server-operator #73
Add metrics-server-operator #73
Conversation
This commit adds metrics-server-operator to `examples/`. As of now dashboard-operator is located in `examples/`. Dashboard v2.0.0 which is next relase can use metrics-server for monitoring statistics of k8s nodes. It's better to add metrics-server-operator to this repo because that dashboard v2.0.0 will release before long. When dashboard v2.0.0 has released, it is needed to add v2.0.0 manifests to dashboard-operator.
/assign @johnsonj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something to consider: This could also live in kubernetes-sigs/cluster-addons. It may also make sense to duplicate the dashboard-operator there?
Overall looks good, please address the super-minor assign copyright comment.
@@ -0,0 +1,36 @@ | |||
/* | |||
Copyright 2020 TODO(akihito): assign copyright. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think The Kubernetes Authors is standard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for comment. I've fixed these.
Thank you @atoato88 ! |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atoato88, johnsonj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@johnsonj I also thought what you considered. 😃 As you comment, we can move these to kubernetes-sigs/cluster-addons. Should we use
But this may need some code changes Or, is |
I think you nailed it that dashboard is an addon and duplication is bad news. Submodules are tough to manage. If we want to make the dashboard-operator useful (and not just an illustrative example of how to use this library) then I think it just doesn't belong here. What about a wilder turn:
|
I agree with your idea. 👍 |
This PR adds metrics-server-operator to
examples/
.As of now dashboard-operator is located in
examples/
.Dashboard v2.0.0 which is next release can use metrics-server for
monitoring statistics of k8s nodes.
It's better to add metrics-server-operator to this repo because that
dashboard v2.0.0 will release before long.
When dashboard v2.0.0 has released, it is needed to add v2.0.0
manifests to dashboard-operator.