Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix decode multi YAML doc #226

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Conversation

xuzhenglun
Copy link
Contributor

What this PR does / why we need it:

previous doc
--- # THIS IS A COMMENT
---   
really doc here

below YAML separator is valid for kubectl but does not work in this repo.

  1. the first separator has some comments.
  2. the second separator has white space at the end of it.

In current behavior, really doc here will treat as a part of previous doc, and really doc here will be eaten in yaml.Unmarshal later.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 24, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @xuzhenglun. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 24, 2022
@k8s-ci-robot k8s-ci-robot requested a review from justinsb June 24, 2022 06:32
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jun 24, 2022
@k8s-ci-robot k8s-ci-robot requested a review from monopole June 24, 2022 06:32
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 24, 2022
@atoato88
Copy link
Contributor

/ok-to-test

Thank you to create, and I'm glad that this PR has unit test! 😄
It help to understand the update.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 27, 2022
@atoato88
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2022
@xuzhenglun
Copy link
Contributor Author

@atoato88

shall we make this progress go-ahead?

@justinsb
Copy link
Contributor

Sorry for delay and thanks for fixing this!

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, xuzhenglun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3d9b297 into kubernetes-sigs:master Jul 11, 2022
@xuzhenglun xuzhenglun deleted the fix-226 branch July 12, 2022 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants