-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix decode multi YAML doc #226
Conversation
Hi @xuzhenglun. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test Thank you to create, and I'm glad that this PR has unit test! 😄 |
/lgtm |
shall we make this progress go-ahead? |
Sorry for delay and thanks for fixing this! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, xuzhenglun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
below YAML separator is valid for
kubectl
but does not work in this repo.In current behavior,
really doc here
will treat as a part ofprevious doc
, andreally doc here
will be eaten inyaml.Unmarshal
later.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation: